Summary: | app-arch/zstd compiles in the install() phase | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Patrick Lauer <patrick> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mrueg |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=619590 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Fixed in zstd-1.1.0 commit 08a6e00d545bb140b543c51ab1bf182f2e7fdf15 Author: Matthias Maier <tamiko@gentoo.org> Date: Mon Oct 3 18:21:13 2016 -0500 app-arch/zstd: version bump to 1.1.0, fix a a number of bugs: - respect "$(get_libdir)" - introduce USE=static-libs, bug #593634 - do not compile library a second time, bug #594514 - respect CC, bug #593630 - prefix support - keyword for x86 Package-Manager: portage-2.3.0 >>> Install zstd-1.1.3 into /tmp/portage/app-arch/zstd-1.1.3/image/ category app-arch make -j1 DESTDIR=/tmp/portage/app-arch/zstd-1.1.3/image/ PREFIX=/usr LIBDIR=/usr/lib64 install make[1]: Entering directory '/tmp/portage/app-arch/zstd-1.1.3/work/zstd-1.1.3/lib' cc -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -I. -I./common -DXXH_NAMESPACE=ZSTD_ -I./legacy -DZSTD_LEGACY_SUPPORT=1 -c -o deprecated/zbuff_compress.o deprecated/zbuff_compress.c cc -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -I. -I./common -DXXH_NAMESPACE=ZSTD_ -I./legacy -DZSTD_LEGACY_SUPPORT=1 -c -o deprecated/zbuff_common.o deprecated/zbuff_common.c cc -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -I. -I./common -DXXH_NAMESPACE=ZSTD_ -I./legacy -DZSTD_LEGACY_SUPPORT=1 -c -o deprecated/zbuff_decompress.o deprecated/zbuff_decompress.c compiling static library creating pkgconfig Installing libraries Installing includes zstd static and shared library installed make[1]: Leaving directory '/tmp/portage/app-arch/zstd-1.1.3/work/zstd-1.1.3/lib' make[1]: Entering directory '/tmp/portage/app-arch/zstd-1.1.3/work/zstd-1.1.3/programs' ==> building zstd with .gz decompression support cc -I../lib -I../lib/common -I../lib/compress -I../lib/dictBuilder -I../lib/legacy -DZSTD_GZDECOMPRESS -DZSTD_LEGACY_SUPPORT=1 -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -lz ../lib/decompress/zstd_decompress.o ../lib/decompress/huf_decompress.o ../lib/common/fse_decompress.o ../lib/common/entropy_common.o ../lib/common/pool.o ../lib/common/error_private.o ../lib/common/xxhash.o ../lib/common/threading.o ../lib/common/zstd_common.o ../lib/compress/zstd_compress.o ../lib/compress/fse_compress.o ../lib/compress/huf_compress.o ../lib/compress/zstdmt_compress.o ../lib/legacy/zstd_v03.o ../lib/legacy/zstd_v04.o ../lib/legacy/zstd_v05.o ../lib/legacy/zstd_v07.o ../lib/legacy/zstd_v01.o ../lib/legacy/zstd_v06.o ../lib/legacy/zstd_v02.o ../lib/dictBuilder/divsufsort.o ../lib/dictBuilder/zdict.o ../lib/dictBuilder/cover.o zstdcli.o fileio.o bench.o datagen.o dibio.o -o zstd -lz Installing binaries Installing man pages zstd installation completed make[1]: Leaving directory '/tmp/portage/app-arch/zstd-1.1.3/work/zstd-1.1.3/programs' >>> Completed installing zstd-1.1.3 into /tmp/portage/app-arch/zstd-1.1.3/image/ I just tested as following: step 1. ebuild zstd-1.1.3.ebuild clean compile step 2. ebuild zstd-1.1.3.ebuild install After step 1 zstd is compiled but not installed. After step 2 it is installed. This is what we expect. I don't see why ago thinks this is not fixed. @blueness: it is enough clear to me: in the install phase, so our src_install where we expect that only the installation is happening I see variuos compile lines: cc -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -I. -I./common -DXXH_NAMESPACE=ZSTD_ -I./legacy -DZSTD_LEGACY_SUPPORT=1 -c -o deprecated/zbuff_compress.o deprecated/zbuff_compress.c cc -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -I. -I./common -DXXH_NAMESPACE=ZSTD_ -I./legacy -DZSTD_LEGACY_SUPPORT=1 -c -o deprecated/zbuff_common.o deprecated/zbuff_common.c cc -g -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -I. -I./common -DXXH_NAMESPACE=ZSTD_ -I./legacy -DZSTD_LEGACY_SUPPORT=1 -c -o deprecated/zbuff_decompress.o deprecated/zbuff_decompress.c and so on....it's just me? :D run emerge zstd instead of ebuild and you will see it clearly. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dbd66e8ddda83af05fcdc387662bf0bdd79987f5 commit dbd66e8ddda83af05fcdc387662bf0bdd79987f5 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2018-11-11 22:25:08 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2018-11-11 22:30:35 +0000 app-arch/zstd: Added multilib support. Don't compile code in src_install() Closes: https://bugs.gentoo.org/594514 Package-Manager: Portage-2.3.51, Repoman-2.3.12 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> app-arch/zstd/zstd-1.3.7-r1.ebuild | 76 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) |
>>> Install zstd-1.0.0 into /tmp/portage/app-arch/zstd-1.0.0/image/ category app-arch make -j1 DESTDIR=/tmp/portage/app-arch/zstd-1.0.0/image/ install make -C lib install make[1]: Entering directory '/tmp/portage/app-arch/zstd-1.0.0/work/zstd-1.0.0/lib' compiling static library compiling dynamic library 1.0.0 creating versioned links creating pkgconfig zstd static and shared library installed