Summary: | media-sound/mac-3.99.4.5.7-r1 : CircleBuffer.cpp:48:57: error: 'min' was not declared in this scope | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Daniel Pielmeier <billie> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | plevine457, sound |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=632150 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 582084 | ||
Attachments: |
emerge-history.txt
environment media-sound:mac-3.99.4.5.7-r1:20160915-162153.log mac-3.99.4.5.7-gcc6.patch |
Description
Toralf Förster
2016-09-15 16:52:19 UTC
Created attachment 445854 [details]
emerge-history.txt
Created attachment 445856 [details]
environment
Created attachment 445858 [details]
media-sound:mac-3.99.4.5.7-r1:20160915-162153.log
Created attachment 446504 [details, diff]
mac-3.99.4.5.7-gcc6.patch
'min' and 'max' are now defined as true functions in gcc-6. Code relying on them as macros will fail. media-sound/mac defines its own 'min' and 'max' macros that conflict with the c++ functions. For trivial cases, it's enough to change min to std::min and max to std::max, to use the library versions. However, many of the uses in media-sound/mac rely on overloads for integer types of which there are none defined (i.e., min(intptr_t, long int)). It seems to me perhaps more correct to rename the macros 'min' and 'max' to 'min_macro' and 'max_macro', respectively, and allow the same behavior as the code's original intent.
Fixed with following commits. Please close. commit 5d5dce5dde1618cfd31e9707d497b3c99cbcf856 Author: Harri Nieminen <moikkis@gmail.com> Date: Sat Mar 4 10:58:51 2017 +0200 media-sound/mac: Fix build with gcc6, EAPI6 Patch from Peter Levine <plevine457@gmail.com> Package-Manager: Portage-2.3.4, Repoman-2.3.2 Closes: https://github.com/gentoo/gentoo/pull/4119 commit 44c26d5015cc5bcfa96159da02e6a27be7bf5bc3 Author: Daniel Pielmeier <billie@gentoo.org> Date: Sat Mar 4 19:31:46 2017 +0100 media-sound/mac: Version bump. Monkeys Audio 4.11 taken from Debian Multimedia including patches. Also includes gcc 6 patch from Github pull request #4119 thanks to Harri Nieminen. Package-Manager: Portage-2.3.3, Repoman-2.3.1 commit 5d5dce5dde1618cfd31e9707d497b3c99cbcf856 Author: Harri Nieminen <moikkis@gmail.com> Date: Sat Mar 4 10:58:51 2017 +0200 media-sound/mac: Fix build with gcc6, EAPI6 Patch from Peter Levine <plevine457@gmail.com> |