Summary: | media-video/vlc-2.2.4 fails to compile against >=media-video/libav-11.7 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | James Ausmus <james.ausmus> |
Component: | Current packages | Assignee: | Nick Andrade <SDNick484> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dronx.wow+gentoo, grknight, media-video, michal.spondr, mwood, olivier, orodruinlair, proxy-maint, saintdev, slawomir.nizio, spookyghost |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/gentoo/gentoo/pull/3122 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
vlc-2.2.4-fix-libav-compile.patch
vlc-2.2.4-r1.ebuild Ebuild Patch Updated vlc-2.2.4-r1.ebuild as of 20161207 |
Description
James Ausmus
2016-09-10 20:41:59 UTC
Created attachment 445420 [details, diff]
vlc-2.2.4-fix-libav-compile.patch
Patch to include the proper header
Created attachment 445422 [details]
vlc-2.2.4-r1.ebuild
ebuild to use the patch
This showed up for me when I turned on the v4l use flag. which might be needed to get this bug to appear. (In reply to James Ausmus from comment #1) > Created attachment 445420 [details, diff] [details, diff] > vlc-2.2.4-fix-libav-compile.patch > > Patch to include the proper header Patch works for me. (In reply to James Ausmus from comment #1) > Created attachment 445420 [details, diff] [details, diff] > vlc-2.2.4-fix-libav-compile.patch > > Patch to include the proper header The patch worked for me as well. Proposed patch works for me too with media-libs/libav-11.7 and media-video/vlc-2.2.4. Though it should probably be checked against older libav versions. Works with the new ebuild+patch. Hey, when this ebuild will be placed in portage tree? Best regards I can confirm this bug. I have the same problem. It's December and the patch is available here since September...? Problem still present with libav 11.8. The provided patch and ebuild work for me. Had the same problem with vlc-2.2.4 and libav-11.8. v4l use flag enabled. Attached patch fixed this. However, the attached ebuild is outdated compared to the vlc-2.2.4.ebuild in tree which has been updated. Will attach an updated ebuild and a ebuild diff to allow future patching of the ebuild to include the vlc-2.2.4-fix-libav-compile.patch file. Created attachment 455310 [details, diff]
Ebuild Patch
Created attachment 455312 [details]
Updated vlc-2.2.4-r1.ebuild as of 20161207
I can confirm this bug. Patch seems to fix it but might want to make it universal instead of conditional by an #ifdef if possible. (In reply to Brian Evans from comment #15) > I can confirm this bug. > > Patch seems to fix it but might want to make it universal instead of > conditional by an #ifdef if possible. I think the issue remains as a result of the ffmpeg/libav fork, and an API change has occurred, which is why the additional header is required (or one implementation includes the functions whilst the other doesn't). It also only seems to manifest when both the 'v4l' and 'libav' flags are used in combination (presumably 'v4l' pulls some function that is contentious between the two implementations). The patch doesn't currently reflect this, but could be easily tweaked to do so. (In reply to Michael Everitt (IRC: veremit) from comment #16) > (In reply to Brian Evans from comment #15) > > I can confirm this bug. > > > > Patch seems to fix it but might want to make it universal instead of > > conditional by an #ifdef if possible. > > I think the issue remains as a result of the ffmpeg/libav fork, and an API > change has occurred, which is why the additional header is required (or one > implementation includes the functions whilst the other doesn't). It also > only seems to manifest when both the 'v4l' and 'libav' flags are used in > combination (presumably 'v4l' pulls some function that is contentious > between the two implementations). The patch doesn't currently reflect this, > but could be easily tweaked to do so. The v4l USE flag is not a concern. I had it off on both libav and vlc and still hit this error. I believe this has been fixed in https://github.com/gentoo/gentoo/commit/5b56b99eeb7c29df23e317f9f3627ac7aa2eeb18 from PR#3122 mentioned above. Thanks, fixed in 2.2.4-r1 (commit 7e29d89c6ffa1ba14c1364c1dc92dcc2f7b9e262). *** Bug 603846 has been marked as a duplicate of this bug. *** |