Summary: | cmake-utils.eclass: Print feature summary | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | arfrever.fta, junghans, polynomial-c |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
CMakeError.log
CMakeOutput.log dev-games:ogre-1.9.0-r1:20160908-190154.log emerge-history.txt environment |
Description
Toralf Förster
![]() Created attachment 445240 [details]
CMakeError.log
Created attachment 445242 [details]
CMakeOutput.log
Created attachment 445244 [details]
dev-games:ogre-1.9.0-r1:20160908-190154.log
Created attachment 445246 [details]
emerge-history.txt
Created attachment 445248 [details]
environment
This seems related to https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac8c7b0f47bb1f266193375b67a6fd566d0f76d5 CC'ing those involved commit 618a26ab975919b551b56d46e4f57d0baa5b22f2 Author: Lars Wendler <polynomial-c@gentoo.org> Date: Thu Sep 8 22:11:53 2016 Revert "cmake-utils.eclass: print feature summary" This reverts commit ac8c7b0f47bb1f266193375b67a6fd566d0f76d5. Makes packages with custom FEATURE_SUMMARY fail as can be seen in https://bugs.gentoo.org/593230 (In reply to Lars Wendler (Polynomial-C) from comment #7) > commit 618a26ab975919b551b56d46e4f57d0baa5b22f2 > Author: Lars Wendler <polynomial-c@gentoo.org> > Date: Thu Sep 8 22:11:53 2016 > > Revert "cmake-utils.eclass: print feature summary" > > This reverts commit ac8c7b0f47bb1f266193375b67a6fd566d0f76d5. > > Makes packages with custom FEATURE_SUMMARY fail as can be seen in > https://bugs.gentoo.org/593230 Actually there is custom FeatureSummary.cmake file in OGRE (not defining any FEATURE_SUMMARY function), which overrides /usr/share/cmake/Modules/FeatureSummary.cmake provided by CMake. According to my testing, include() command handles its argument in case-sensitive way, so include(FeatureSummary) would include FeatureSummary.cmake but not e.g. featuresummary.cmake. It would probably suffice to check existence of FeatureSummary.cmake in ${WORKDIR}: if ! grep -Fiq FEATURE_SUMMARY "${CMAKE_USE_DIR}"/CMakeLists.txt && [[ -z $(find "${WORKDIR}" -name FeatureSummary.cmake -type f) ]]; then Couldn't we use include(${EPREFIX}/usr/share/cmake/Modules/FeatureSummary.cmake) in cmake-utils.cmake? As this has already broken once in unexpected ways (on a stable package no less), I'm not keen to repeat. I still maintain my original position that this sort of thing does not belong in the main tree (and is of limited value anyway). (In reply to Michael Palimaka (kensington) from comment #10) > As this has already broken once in unexpected ways (on a stable package no > less), I'm not keen to repeat. > > I still maintain my original position that this sort of thing does not > belong in the main tree (and is of limited value anyway). I second this. |