| Summary: | sys-apps/busybox-1.0.0_pre20040726.ebuild: CFLAGS are ignored (not applied to OPTIMIZATION) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Stefan Nickl <snickl> |
| Component: | New packages | Assignee: | Embedded Gentoo Team <embedded> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | natanael.copa |
| Priority: | High | ||
| Version: | 2004.1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 59506 | ||
Thanks. I'll add this the next time I take a busybox snapshot. I've given this some thought and passing the entire CFLAGS here wont be safe. We need a subset of them that are strictly OPIMIZATION flags. If you need to pass ABI flags or other thats fine but I don't think passing all of CFLAGS is going to be ideal here as this very thing is what could break busybox's cross compiling support. I think we may even of had OPTIMIZATION=CFLAGS before and learned this the hardway. Since busybox-1.0.0_pre20040726.ebuild does not exist in portage anymore, would it be an idea to just close this bug? (In reply to comment #3) > Since busybox-1.0.0_pre20040726.ebuild does not exist in portage anymore, would > it be an idea to just close this bug? > The issue still persists in current ebuilds, but OTOH it doesn't look like there will be a perfect solution anytime soon, so I wouldn't object to closing the entry. As a compromise, maybe the line could be changed to simply include 'OPTIMIZATION="-Os"'. fixed in 1.1.0 and 1.1.1 |
When emerging busybox, the defaults from Rules.mak are used instead of the /etc/make.conf CFLAGS setting. Can easily be fixed by changing src_compile() from: emake -j1 CROSS="${CROSS}" busybox || die to: emake -j1 CROSS="${CROSS}" OPTIMIZATION="${CFLAGS}" busybox || die