| Summary: | dev-qt/qtwebengine does not respect MAKEOPTS="-jN" | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Chí-Thanh Christopher Nguyễn <chithanh> |
| Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aliens.satin0y, bob.mt.wya, Dan.Johansson, eugene.shalygin, gentoo-bugs-augustin, nrndda |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=590920 https://bugs.gentoo.org/show_bug.cgi?id=559064 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Chí-Thanh Christopher Nguyễn
2016-09-01 13:03:32 UTC
MAKEOPTS needs munging before being passed to NINJAOPTS - we cannot assign it verbatim. Bug #590920 comment #2 suggests introducing a new eclass, instead of duplicating the login in cmake-utils. Thoughts? (In reply to Michael Palimaka (kensington) from comment #1) > Bug #590920 comment #2 suggests introducing a new eclass, instead of > duplicating the login in cmake-utils. Thoughts? Sounds sensible to me. Note that multiprocessing.eclass also has makeopts_jobs() and makeopts_loadavg() functions to extract those values from MAKEOPTS. NINJAFLAGS="-j1" ? Has there been any progress? This bug is affecting all systems with low memory. (In reply to Thomas Jürges from comment #4) There is a new ninja-utils eclass which has been committed last week. Porting qtwebengine ebuild to it would presumably solve the problem. Until then, set NINJAFLAGS as a workaround per comment 0 and comment 3. I can confirm that setting the environment variable NINJAFLAGS alleviates the issue.
Cheers
T.
(In reply to Chí-Thanh Christopher Nguyễn from comment #5) > (In reply to Thomas Jürges from comment #4) > There is a new ninja-utils eclass which has been committed last week. > Porting qtwebengine ebuild to it would presumably solve the problem. The ebuild doesn't call ninja directly, it's wrapped by a qmake-based build system. So we can't use the eninja eclass function. I pushed a fix to the overlay for testing: https://gitweb.gentoo.org/proj/qt.git/commit/?id=3210bde4818f62d3acef982a1311f1ba2be8a020 If someone is able to confirm that this approach works, I'll land it in main tree too. I used the wrong variable name. Fixed commit: https://gitweb.gentoo.org/proj/qt.git/commit/?id=522bef331aed4670a4c97d635d6d9fe8df0bb31e Thanks, fixed in git. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90f45d0172ad22d6b8a6e77025499156b704dcc9 (In reply to Michael Palimaka (kensington) from comment #8) > I pushed a fix to the overlay for testing: > > https://gitweb.gentoo.org/proj/qt.git/commit/ > ?id=3210bde4818f62d3acef982a1311f1ba2be8a020 > > If someone is able to confirm that this approach works, I'll land it in main > tree too. what if someone wants to use custom NINJAFLAGS? (In reply to Jan Chren (rindeal) from comment #11) > what if someone wants to use custom NINJAFLAGS? Good point. (In reply to Jan Chren (rindeal) from comment #11) I suggest: export NINJAFLAGS="${NINJAFLAGS:--j$(makeopts_jobs) -l$(makeopts_loadavg "${MAKEOPTS}" 0) -v}" |