Summary: | dev-libs/liblognorm-1.1.3-r1 with >=dev-libs/libfastjson-0.99.4 - enc_syslog.c:189:35: error: ‘name’ undeclared (first use in this function) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeroen Roovers (RETIRED) <jer> |
Component: | Current packages | Assignee: | Thomas Deutschmann (RETIRED) <whissi> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andreis.vinogradovs, maksbotan |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | dev-libs:liblognorm-1.1.3-r1:20160826-081931.log.xz |
Description
Jeroen Roovers (RETIRED)
![]() [ebuild R ~] dev-libs/libfastjson-0.99.4:0/4.0.0::gentoo USE="-static-libs" 0 KiB [ebuild R ] dev-libs/liblognorm-1.1.3-r1:0/2::gentoo USE="{test} -debug -doc -static-libs" 0 KiB Thanks for the report. I decided to drop liblognorm-1.1.3 in favor of v2.0.1:
> commit 781fcdf56b363fd3aefad076a9a092d4df37e00c
> Author: Thomas Deutschmann
> Date: Sun Aug 28 20:32:56 2016 +0200
>
> dev-libs/liblognorm: Dropping v1.1.3-r1
>
> v1.1.3 only builds against <dev-libs/libfastjson-0.99.4. Because upstream already
> moved to v2.0.x and nothing else is using dev-libs/liblognorm-1.1.3-r1 I am
> dropping this version in favor of v2.0.1 which is already in the repository.
>
> Gentoo-Bug: https://bugs.gentoo.org/592302
>
> Package-Manager: portage-2.3.0
Keywords for dev-libs/liblognorm: | a a a h i p p s x m a m n r s s | e u s | r | l m r p a p p p 8 i r 6 i i 3 h | a n l | e | p d m p 6 c c a 6 p m 8 o s 9 | p u o | p | h 6 a 4 6 r s 6 k s c 0 | i s t | o | a 4 4 c 4 2 v | e | | | d | ---------+---------------------------------+-------------+------- 1.1.0 | o + + + o o o o + o o o o o o o | 5 o 0/1 | gentoo ---------+---------------------------------+-------------+------- 1.1.2-r1 | o + ~ + o o o o + o o o o o o o | 5 o 0/2 | gentoo 1.1.3-r1 | o ~ ~ + o o o o ~ o o o o o o o | 6 o | gentoo ---------+---------------------------------+-------------+------- 2.0.1 | o ~ ~ ~ o o o o ~ o o o o o o o | 6 o 0/5.0.0 | gentoo Pity about the stable keyword, right? Yes, that we had to force a downgrade for HPPA isn't nice. But in this case it was necessary and because no consumer was yet stabilized it shouldn't affect many people/systems: 1) v1.1.3 is incompatible with >dev-libs/libfastjson-0.99.2. If we wanted to keep v1.1.3 in tree we would have to update the version requirement in DEPEND. There's a v1.1.4 but it wasn't official released: http://lists.adiscon.net/pipermail/rsyslog/2016-August/043195.html 2) Additional, while testing I experienced runtime errors if you are running rsyslog which was build against dev-libs/json-c (which is the case if you are using rsyslog-8.16.0 since it became stable before dev-libs/libfastjson appeared in the repository) and mix it with dev-libs/liblognorm which was build against dev-libs/libfastjson. Also rsyslog-8.16.0 itself picks up dev-libs/libfastjson if available which wasn't reflected in the ebuild (and like liblognorm, this rsyslog version also doesn't build against >dev-libs/libfastjson-0.99.2). So instead of bumping liblognorm to v1.1.4 or to cherry pick a fix from a non-released upstream version and still dealing with runtimes errors which would require multiple changed DEPs to get fixed I only patched the already stabilized =app-admin/rsyslog-8.16.0-r1 atom to not pick up dev-libs/libfastjson and restricted the liblognorm version usage (85ef4a41db344646dbb93d8583a231bc2058f0d6). Yes, I could have kept liblognorm-1.1.3 with adjusted DEPs in tree however due to 173c0d996ecbd41cf47770e97c8b3c9904b4d376 we really don't need this version anymore (and v2.0.1 works with both libfastjson versions in repository and is compatible with v1.x configurations). I hope you understand and agree with my solution. If you would have solved this differently please share so that I can do it better next time. Thanks! |