Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 591816

Summary: net-misc/icaclient - Allow users to avoid having to install selfservice deps
Product: Gentoo Linux Reporter: Hypnos <hypnos75>
Component: Current packagesAssignee: Lars Wendler (Polynomial-C) <polynomial-c>
Status: UNCONFIRMED ---    
Severity: enhancement CC: nbowler
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://docs.citrix.com/en-us/receiver/linux/current-release/system-requirements.html
See Also: https://bugs.gentoo.org/show_bug.cgi?id=627554
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: icaclient-13.3.0.344519-r1.ebuild.patch
icaclient-13.3.0.344519-r1.ebuild.patch

Description Hypnos 2016-08-21 16:01:55 UTC
Created attachment 443824 [details, diff]
icaclient-13.3.0.344519-r1.ebuild.patch

The selfservice dependences are rather heavy (e.g., webkit-gtk), and the receiver works quite well without them.  I have modified the ebuild to add a non-default USE flag "receiver-only" which allows users to install only the deps needed for the receiver to function (ebuild patch attached).

Caveat: I have only tested this on the one Citrix app I use, Charles Schwab Streetsmart Edge.
Comment 1 Lars Wendler (Polynomial-C) gentoo-dev 2016-08-22 09:28:58 UTC
So you've modified the dependencies but the selfservice executable still gets installed. Any reason for that?
Please rename "receiver-only" USE flag to "minimal".
Also your change is not really easy to maintain. Please combine all dependencies into one single USE dependency:

!minimal? (
    dep1
    dep2
    dep3
    dep4
    ...
)

Put this block at the end of the dependencies and make sure the list is alphabetically sorted.
Comment 2 Hypnos 2016-08-22 13:24:32 UTC
Created attachment 443854 [details, diff]
icaclient-13.3.0.344519-r1.ebuild.patch

It was an oversight to install selfservice and ServiceRecord, though the OEM "receiver only" deb package does install them.  Installing these are now contingent on the "minimal" USE flag, which I have implemented as you specified.

Finally, I added the libXpm and libidn dependencies, which are required according the deb packages.
Comment 3 Pacho Ramos gentoo-dev 2017-02-08 12:49:11 UTC
We also need to avoid webkit-gtk:2 dep because it's going to be removed in the near future due to its security issues and because of being unmaintained for years