Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 591516

Summary: sys-devel/binutils-2.26.1 bundles zlib
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Gentoo Toolchain Maintainers <toolchain>
Status: RESOLVED FIXED    
Severity: normal CC: qa
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 595148    
Deadline: 2016-10-14   
Attachments: toolchain-binutils.eclass.diff

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-08-17 14:43:22 UTC
make[2]: Wejście do katalogu '/var/tmp/portage/sys-devel/binutils-2.26.1/work/build/zlib'
i686-pc-linux-gnu-gcc-5.4.0 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACK
AGE_URL=\"\" -DPACKAGE=\"zlib\" -DVERSION=\"1.1.4\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -
DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_STDLIB_H
=1 -DHAVE_UNISTD_H=1 -DHAVE_GETPAGESIZE=1 -DHAVE_MMAP=1 -DHAVE_MEMCPY=1 -DHAVE_STRERROR=1 -DHAVE_UNISTD_H=1 -I. -I/var/tmp/portage/sys-devel/binuti
ls-2.26.1/work/binutils-2.26.1/zlib     -fPIC -O2 -pipe -march=pentium-m -c -o libz_a-adler32.o `test -f 'adler32.c' || echo '/var/tmp/portage/sys-
devel/binutils-2.26.1/work/binutils-2.26.1/zlib/'`adler32.c
i686-pc-linux-gnu-gcc-5.4.0 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACK
AGE_URL=\"\" -DPACKAGE=\"zlib\" -DVERSION=\"1.1.4\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -
DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_STDLIB_H
=1 -DHAVE_UNISTD_H=1 -DHAVE_GETPAGESIZE=1 -DHAVE_MMAP=1 -DHAVE_MEMCPY=1 -DHAVE_STRERROR=1 -DHAVE_UNISTD_H=1 -I. -I/var/tmp/portage/sys-devel/binuti
ls-2.26.1/work/binutils-2.26.1/zlib     -fPIC -O2 -pipe -march=pentium-m -c -o libz_a-compress.o `test -f 'compress.c' || echo '/var/tmp/portage/sy
s-devel/binutils-2.26.1/work/binutils-2.26.1/zlib/'`compress.c

[...]
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-08-17 14:44:22 UTC
[ebuild  NS    ] sys-devel/binutils-2.26.1:2.26.1::gentoo [2.25.1-r1:2.25.1::gentoo] USE="nls zlib -cxx -multitarget -static-libs {-test} -vanilla"
 0 KiB

Portage 2.3.0 (python 3.4.4-final-0, default/linux/x86/13.0/desktop, gcc-5.4.0, glibc-2.23-r2, 4.4.0-pf3-mgorny-x86+ i686)
=================================================================
System uname: Linux-4.4.0-pf3-mgorny-x86+-i686-Intel-R-_Celeron-R-_M_processor_1500MHz-with-gentoo-2.2
Timestamp of repository gentoo: Wed, 17 Aug 2016 11:24:22 +0000
sh bash 4.3_p46
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
distcc 3.2rc1 i686-pc-linux-gnu [enabled]
app-shells/bash:          4.3_p46::gentoo
dev-lang/perl:            5.24.0-r1::gentoo
dev-lang/python:          2.7.11-r2::gentoo, 3.4.4::gentoo
dev-util/cmake:           3.6.0::gentoo
dev-util/pkgconfig:       0.29.1::gentoo
sys-apps/baselayout:      2.2-r1::gentoo
sys-apps/openrc:          0.21.2::gentoo
sys-apps/sandbox:         2.10-r2::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r2::gentoo
sys-devel/automake:       1.11.6-r2::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            5.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.6::gentoo (virtual/os-headers)
sys-libs/glibc:           2.23-r2::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-umask: 027
    sync-uri: https://github.com/gentoo/gentoo-portage-rsync-mirror
    priority: -1000

mgorny
    location: /home/mgorny/mgorny-repo
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="* -@EULA"
CBUILD="i686-pc-linux-gnu"
CC="i686-pc-linux-gnu-gcc-5.4.0"
CFLAGS="-O2 -pipe -march=pentium-m --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXX="i686-pc-linux-gnu-g++-5.4.0"
CXXFLAGS="-O2 -pipe -march=pentium-m --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512"
DISTDIR="/var/cache/portage/distfiles"
EMERGE_DEFAULT_OPTS="--ask --with-bdeps y --keep-going --dynamic-deps=n"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg cgroup collision-protect config-protect-if-modified distcc distlocks ebuild-locks fixlafiles lmirror merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -march=i686 -pipe"
GENTOO_MIRRORS="http://pomiot.local/ 	http://mirror.netcologne.de/gentoo/ http://gentoo.mirror.web4u.cz/ http://ftp.snt.utwente.nl/pub/os/linux/gentoo http://gd.tuwien.ac.at/opsys/linux/gentoo/ http://gentoo.mirror.pw.edu.pl/ http://ftp.vectranet.pl/gentoo/ http://ftp.fi.muni.cz/pub/linux/gentoo/"
LANG="pl_PL.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed"
MAKEOPTS="-j12"
PKGDIR="/var/cache/portage/packages"
PORTAGE_COMPRESS="lzip"
PORTAGE_COMPRESS_FLAGS="-9"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi adns alsa amr bash-completion berkdb bluetooth branding bzip2 cairo caps cdda cdr cli cracklib crypt cups cxx dbus djvu dri dts dvd dvdr emboss encode exif fam fftw firefox flac fortran gd gdbm gif glamor gmp gnome-keyring gnutls gphoto2 gtk hdri iconv icu id3tag idn imagemagick ipv6 jbig jit jpeg jpeg2k lapack lcms libedit liblockfile libnotify libsecret lzma lzo mad mmx mng modules mp3 mp4 mpeg mpfr ncurses nls nptl ogg openexr opengl openmp opus pam pango pcre pdf png policykit ppds qt3support qt4 readline schroedinger sdl seccomp session smp sndfile speex spell sse sse2 ssl startup-notification svg systemd tcpd theora threads tiff truetype udev udisks unicode upnp upower usb v4l vim-syntax vorbis vpx webp wmf wxwidgets x264 x86 xattr xcb xcomposite xml xpm xv xvid zlib" ABI_X86="32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="pl" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" QEMU_SOFTMMU_TARGETS="x86_64 alpha arm cris i386 lm32 m68k microblaze microblazeel mips mips64 mips64el mipsel moxie or32 ppc ppc64 ppcemb s390x sh4 sh4eb sparc sparc64 unicore32 xtensa xtensaeb" QEMU_USER_TARGETS="alpha arm armeb cris i386 m68k microblaze microblazeel mips mips64 mips64el mipsel mipsn32 mipsn32el or32 ppc ppc64 ppc64abi32 s390x sh4 sh4eb sparc sparc32plus sparc64 unicore32 x86_64" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-08-18 06:42:59 UTC
Created attachment 443636 [details, diff]
toolchain-binutils.eclass.diff

Given the fact that we don't have binutils versions in portage that do not have zlib support, something small like the attached patch might be sufficient to make use of system-zlib in >=binutils-2.26

We should keep in mind to also add "--with-system-zlib" to any newer sys-libs/binutils-libs package once it gets a newer version.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-10-07 08:03:13 UTC
Guys, this is a trivial change with no side effects.

I will commit this change in about a week if nobody from toolchain team takes care of it before.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-10-17 09:04:32 UTC
commit 6df9297eb84f754944feb031d23e9706057ddfc8
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Mon Oct 17 10:11:21 2016

    toolchain-binutils.eclass: Don't use bundled zlib (bug #591516).
Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-10-17 12:27:35 UTC
Sorry guys, I copied the log entry before the rebase was done...


commit 8c1495faa17c824d18ca53e263703431f8d19117
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Mon Oct 17 10:11:21 2016

    toolchain-binutils.eclass: Don't use bundled zlib (bug #591516).
Comment 6 SpanKY gentoo-dev 2016-11-15 06:51:55 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #2)

the version in the tree doesn't matter -- the eclass supports versions in the overlay too which dates back to at least 2.14

should be fixed for all versions now with this update:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd3431dcd1c50f6dcbd543792d0b8cdc2808da47