Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 590890

Summary: app-emacs/desktop+: new package
Product: Gentoo Linux Reporter: Victor Gaydov <victor>
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: RESOLVED FIXED    
Severity: enhancement CC: gnu-emacs, proxy-maint, victor
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/gentoo/gentoo/pull/2050
Whiteboard:
Package list:
Runtime testing required: ---

Description Victor Gaydov 2016-08-09 16:23:20 UTC
Hi,

desktop+[1] extends standard desktop module.

It depends on:

* dash (already in portage)
* f.el[2] (new package)
* s.el[3] (dependency of f.el, new package)

See PR on github[4].

[1] https://github.com/ffevotte/desktop-plus
[2] https://github.com/rejeep/f.el
[3] https://github.com/magnars/s.el
[4] https://github.com/gentoo/gentoo/pull/2050
Comment 1 Victor Gaydov 2016-08-10 09:39:52 UTC
Forgot to mention, I would like to proxy-maintain this package (corresponding metadata is already added to the PR).
Comment 2 Ulrich Müller gentoo-dev 2016-08-15 19:38:36 UTC
[Sorry for the delay, I returned from holidays and have quite some backlog.]

Generally we avoid adding an -el suffix to package names (unless it is the upstream name). The packages are named "f" and "s" on MELPA, so our package names should be app-emacs/f and app-emacs/s.

Eclass functions elisp-compile and elisp-make-autoload-file die by themselves, so there is no need for an extra "|| die" there.
Comment 3 Victor Gaydov 2016-08-16 11:21:31 UTC
Great. The PR[1] is updated.

I've also fixed other ebuilds that I sent earlier, see the second PR[2].

[1] https://github.com/gentoo/gentoo/pull/2050
[2] https://github.com/gentoo/gentoo/pull/2092
Comment 4 Ulrich Müller gentoo-dev 2016-09-08 14:12:45 UTC
All good to go.

Sorry for the delay, I was waiting for proxy-maintainers, and vice versa.
Comment 5 Patrice Clement gentoo-dev 2016-09-09 13:35:58 UTC
commit e42fea502aac38af57b6049eb412af9daeacb46b (HEAD -> master, origin/master, origin/HEAD)
Author:     Victor Gaydov <victor@enise.org>
AuthorDate: Tue Aug 9 19:14:26 2016 +0300
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Fri Sep 9 15:34:39 2016 +0200

app-emacs/desktop+: new package.

desktop+ extends desktop by providing more features related to
sessions persistance.

Gentoo-Bug: https://bugs.gentoo.org/590890
Closes: https://github.com/gentoo/gentoo/pull/2050

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

app-emacs/desktop+/Manifest                   |  1 +
app-emacs/desktop+/desktop+-0.2.ebuild        | 27 +++++++++++++++++++++++++++
app-emacs/desktop+/files/50desktop+-gentoo.el |  2 ++
app-emacs/desktop+/metadata.xml               | 16 ++++++++++++++++
4 files changed, 46 insertions(+)
create mode 100644 app-emacs/desktop+/Manifest
create mode 100644 app-emacs/desktop+/desktop+-0.2.ebuild
create mode 100644 app-emacs/desktop+/files/50desktop+-gentoo.el
create mode 100644 app-emacs/desktop+/metadata.xml

The two deps have also been added. Thanks a lot!