Summary: | games-roguelike/rimworld: sci fi colony sim driven by an intelligent AI storyteller | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Mike Nerone <mike> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | games, proxy-maint |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://rimworldgame.com/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | games-roguelike/rimworld-0.0.14.1249e.ebuild |
Description
Mike Nerone
2016-08-07 07:04:19 UTC
CC games team to see if they are interested. Note: The attached ebuild still works for the current version of Rimworld, Alpha 15c. Just needs rename to rimworld-0.0.15.1284c.ebuild. Mike, given that Rimworld is a commercial game and as such only people owning it would be able to fully test the ebuilds, would you perhaps be willing to become the proxied maintainer of this package? You would then be the person working on the ebuilds and someone from the dedicated Gentoo team [1] would push your changes to Portage. [1]: https://wiki.gentoo.org/index.php?title=Project:Proxy_Maintainers (In reply to Marek Szuba from comment #3) Sure, I can do that. I *would* like for someone to take a look at the ebuild and at make sure it looks right (particularly my guess at multilib treatment). If someone can step up who can test the 32-bit build, that would be great, too. I have no way to actually test that. Great! We will of course have a look at your ebuilds, that's what the Proxy Maintainers project is for. It would be good if you could come to IRC at some point to discuss the matter, it is faster that way... Meanwhile, have a look at the links in the Resources section of the page I have linked, they will help you validate your ebuilds and give you some hints on the best way of submitting your ebuilds. Overall the ebuild as it is looks quite okay but there are a few things which should still be improved: * the games eclass is deprecated, just conduct the necessary operations by hand; * every file-system operation should be followed by an "or die in case of an error" clause unless it really doesn't matter if the operation succeeds or not. Yes, even rm - in theory it *can* fail; * I think you should commit the Ludeon EULA to Portage and use that as LICENCE instead of using all-rights-reserved; * there is no need to inherit the unpacker eclass; * you've already got "RimWorld" assigned to ${HUMAN_PN} so just use that elsewhere in the ebuild instead of repeating the literal string; * come to think of it, you might consider generating ${HUMAN_PN} from ${PN} too; * there are a couple of places where variables are used unquoted. Regarding the testing on x86, the common way of doing that these days is to set up a chroot environment on an amd64 system. Until it has been tested though, just drop ~x86 from KEYWORDS. PS. I think we might have to revisit the subject of version numbers at some point. Hi, any news on this? If not, we would like to close this bug as WONTFIX (for now anyway) following the usual 30 days of waiting. |