Bug 590490

Summary:	sci-libs/libqalculate-0.9.9[-readline]: build failure: qalc.cc:3182:11: error: 'historyfile' was not declared in this scope
Product:	Gentoo Linux	Reporter:	Ryoto Yayame <kanito.tasoga>
Component:	Current packages	Assignee:	Gentoo Science Related Packages <sci>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PATCH
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/Qalculate/libqalculate/issues/6
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	596672
Attachments:	Patch for libqalculate-0.9.9

Description Ryoto Yayame 2016-08-04 17:10:47 UTC

Created attachment 442528 [details, diff]
Patch for libqalculate-0.9.9

Emerging libqalculate-0.9.9 with USE="-readline" fails with:

> qalc.cc: In function 'void load_preferences()':
> qalc.cc:3182:11: error: 'historyfile' was not declared in this scope
>     g_free(historyfile);

Variable 'historyfile' is indeed only declared in this function, if HAVE_LIBREADLINE has been defined. This line was missed when #ifdef'ing the other uses of this variable.

Patch attached. Emerges fine with it.

I reported it upstream here:
https://github.com/Qalculate/libqalculate/issues/6

Comment 1 Pacho Ramos gentoo-dev

2016-11-27 12:43:09 UTC

[master eef49a7] sci-libs/libqalculate: Fix compilation with -readline USE (#590490 by Ryoto Yayame)
 2 files changed, 18 insertions(+)
 create mode 100644 sci-libs/libqalculate/files/libqalculate-0.9.9-readline.patch