Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 590166

Summary: net-misc/vinagre-3.20.2-r1 stable request
Product: Gentoo Linux Reporter: Mike Gilbert <floppym>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: anton.gubarkov, tom
Priority: Normal Keywords: STABLEREQ
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://bugzilla.gnome.org/show_bug.cgi?id=765444
Whiteboard: Was: net-misc/vinagre-3.20.2 fails to build against net-misc/freerdp-2.0.0_pre20160722
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 601720    
Attachments: build log
configure log

Description Mike Gilbert gentoo-dev 2016-07-31 23:13:08 UTC
Created attachment 442126 [details]
build log

configure:4759: $PKG_CONFIG --exists --print-errors "$RDP_DEPS"
Package freerdp was not found in the pkg-config search path.
Perhaps you should add the directory containing `freerdp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'freerdp', required by 'world', not found
configure:4762: $? = 1
configure:4789: error: RDP support requested but required dependencies not found


freerdp.pc was renamed to freerdp2.pc.
Comment 1 Mike Gilbert gentoo-dev 2016-07-31 23:14:02 UTC
Created attachment 442128 [details]
configure log
Comment 2 Mike Gilbert gentoo-dev 2016-08-01 00:12:49 UTC
commit ccd8a890ed907252da2878abc3fc37f38cf12d58
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Sun Jul 31 20:11:35 2016 -0400

    net-misc/vinagre: depend on <net-misc/freerdp-2
    
    Bug: https://bugs.gentoo.org/590166
    Package-Manager: portage-2.3.0_p16

 net-misc/vinagre/vinagre-3.18.2.ebuild | 4 ++--
 net-misc/vinagre/vinagre-3.20.2.ebuild | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 3 Kobboi 2016-08-04 11:59:09 UTC
The newest net-misc/remmina (1.2.0_rc14) depends on freerdp-2. How is this handled normally? Just choose and live with it? Or is it a reason to request slotting?
Comment 4 Mike Gilbert gentoo-dev 2016-08-04 14:35:41 UTC
Ideally, vinagre would be ported to use the new freerdp version.

Until that happens, you'll have to choose one or the other.

Regarding slotting: possible in theory, but it would take some work. I'll consider it if this bug goes unresolved for a while.
Comment 5 Thomas Scheiblauer 2016-10-04 07:15:16 UTC
In the case of having to choose between these two packages involuntarily, e.g. a use flag should be added to gnome-base/gnome-extra-apps to be able to exclude Vinagre from its dependencies!
Comment 6 Mike Gilbert gentoo-dev 2016-10-05 13:40:42 UTC
(In reply to Thomas Scheiblauer from comment #5)

Or you could just disable the "rdp" USE flag on vinagre.
Comment 7 Thomas Scheiblauer 2016-10-05 14:51:51 UTC
True, but when someone chooses to use Remmina, a second package fulfilling essentially the same purpose would probably be unnecessary ballast.
Comment 8 Pacho Ramos gentoo-dev 2016-12-07 18:25:16 UTC
*** Bug 601910 has been marked as a duplicate of this bug. ***
Comment 9 Pacho Ramos gentoo-dev 2016-12-07 18:26:11 UTC
This patch from Fedora could help:
http://pkgs.fedoraproject.org/cgit/rpms/vinagre.git/tree/0001-handle-new-freerdp-pkgconfig-name.patch
Comment 10 Anton Gubarkov 2016-12-08 09:45:52 UTC
(In reply to Pacho Ramos from comment #9)
> This patch from Fedora could help:
> http://pkgs.fedoraproject.org/cgit/rpms/vinagre.git/tree/0001-handle-new-
> freerdp-pkgconfig-name.patch

vinagre-3.22.0.ebuild still has 
 rdp? ( <net-misc/freerdp-2 )
preventing the build from starting
Comment 11 Pacho Ramos gentoo-dev 2016-12-08 10:23:22 UTC
[master 6ba6e38] net-misc/vinagre: Be compatible with freerdp-2 (#590166)
 3 files changed, 176 insertions(+)
 create mode 100644 net-misc/vinagre/files/vinagre-3.20.2-freerdp2.patch
 create mode 100644 net-misc/vinagre/vinagre-3.20.2-r1.ebuild
 create mode 100644 net-misc/vinagre/vinagre-3.22.0-r1.ebuild
Comment 12 Pacho Ramos gentoo-dev 2016-12-09 10:51:51 UTC
amd64/x86 stable