Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 590098

Summary: [ICE/4.9/5.4] attempting to build media-libs/libraw on musl libc
Product: Gentoo Linux Reporter: A. Wilcox (awilfox) <awilfox.gentoo>
Component: Current packagesAssignee: Gentoo musl team <musl>
Status: RESOLVED FIXED    
Severity: normal CC: tsmksubc
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71702
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 430702    
Attachments: tree-vect-data-refs correctness patch for gcc

Description A. Wilcox (awilfox) 2016-07-30 23:50:30 UTC
Created attachment 442028 [details, diff]
tree-vect-data-refs correctness patch for gcc

Attempting to build media-libs/libraw on the musl libc tickles a bug in vect_analyze_data_ref_accesses on GCC 4.9 and 5.4 (only ones I tested, apparently 5.3 is also affected).

The attached patch, from upstream, resolves this issue.  As upstream seems to be unwilling to push out a new GCC 4.9 version, and 5.4 did not include this particular fix, it may be beneficial to carry this patch in the Gentoo patch set.
Comment 1 Anthony Basile gentoo-dev 2016-07-31 02:12:20 UTC
(In reply to A. Wilcox (awilfox) from comment #0)
> Created attachment 442028 [details, diff] [details, diff]
> tree-vect-data-refs correctness patch for gcc
> 
> Attempting to build media-libs/libraw on the musl libc tickles a bug in
> vect_analyze_data_ref_accesses on GCC 4.9 and 5.4 (only ones I tested,
> apparently 5.3 is also affected).
> 
> The attached patch, from upstream, resolves this issue.  As upstream seems
> to be unwilling to push out a new GCC 4.9 version, and 5.4 did not include
> this particular fix, it may be beneficial to carry this patch in the Gentoo
> patch set.

Looks good to me.

@vapier, any reason not to back port this to 4.9 and 5.x?
Comment 2 Anthony Basile gentoo-dev 2016-07-31 02:13:09 UTC
(In reply to Anthony Basile from comment #1)
> 
> Looks good to me.
> 
> @vapier, any reason not to back port this to 4.9 and 5.x?

Actually I should say I'll add this to the gcc ebuild on the musl overlay for now.
Comment 3 Anthony Basile gentoo-dev 2016-09-19 08:10:32 UTC
(In reply to A. Wilcox (awilfox) from comment #0)
> Created attachment 442028 [details, diff] [details, diff]
> tree-vect-data-refs correctness patch for gcc
> 
> Attempting to build media-libs/libraw on the musl libc tickles a bug in
> vect_analyze_data_ref_accesses on GCC 4.9 and 5.4 (only ones I tested,
> apparently 5.3 is also affected).
> 
> The attached patch, from upstream, resolves this issue.  As upstream seems
> to be unwilling to push out a new GCC 4.9 version, and 5.4 did not include
> this particular fix, it may be beneficial to carry this patch in the Gentoo
> patch set.

Can you get me a reference to the upstream commit for this?
Comment 4 Anthony Basile gentoo-dev 2016-09-19 20:15:11 UTC
(In reply to Anthony Basile from comment #3)
> 
> Can you get me a reference to the upstream commit for this?

Never mind, we found it.  I think we're going to go directly from gcc-4 to gcc-6 where this patch is not needed.  So I think pushing this onto the musl overlay is sufficient.  sys-devel/gcc::musl is going away when we stabilize gcc-6.
Comment 5 Anthony Basile gentoo-dev 2017-11-27 14:39:25 UTC
(In reply to Anthony Basile from comment #4)
> (In reply to Anthony Basile from comment #3)
> > 
> > Can you get me a reference to the upstream commit for this?
> 
> Never mind, we found it.  I think we're going to go directly from gcc-4 to
> gcc-6 where this patch is not needed.  So I think pushing this onto the musl
> overlay is sufficient.  sys-devel/gcc::musl is going away when we stabilize
> gcc-6.

With gcc-6 on the way to being stabilized, this is no longer needed.