Summary: | media-plugins/gst-plugins-opus-1.8.2 does not provide opus support (migration to -base) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Nils Freydank <holgersson> |
Component: | Current packages | Assignee: | GStreamer package maintainers <gstreamer> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | holgersson, josef64, tamiko |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Proposed patch for media-plugins/gst-plugins-opus-1.8.2 |
Description
Nils Freydank
2016-07-23 10:40:36 UTC
See also (Release Notes): https://gstreamer.freedesktop.org/releases/1.8/ Created attachment 441418 [details, diff]
Proposed patch for media-plugins/gst-plugins-opus-1.8.2
[master ced7664] media-libs/gst-plugins-base: Enable opus support (#589440 by holgersson) 2 files changed, 6 insertions(+), 2 deletions(-) Reopening, as this should have probably been a conversion of gst-plugins-opus to use GST_ORG_MODULE=gst-plugins-base instead of USE flaggery on main -base. Need to look at that before 1.8 series goes stable. The complex bit is on deciding what to do with the parser bits that remaining in -bad for now. Need to see if that's even useful in any way if it was left behind, etc. So this open bug is a reminder for looking into this. yup, checked with upstream: <leio> Is opusparse important for opus pipelines, despite being left in -bad for now? <__tim> no <leio> So the glorious Opus codec world doesn't end in Gentoo if I axe opusparse plugin from -bad completely for now? <__tim> it doesn't, no <leio> now beyond packaging, what does it do then? :) <__tim> I think it's supposed to parse the test streams which are framed slightly differently, but last I checked it didn't match the spec for those, so it's all a bit puzzling really So we should forget about the gst-plugins-bad ext/opus/, have gst-plugins-opus GST_ORG_MODULE=gst-plugins-base and kill it from -base. And then stable that, not this moving around. If you got rid of gst-plugins-opus based on the blockers and whatnot before, you should install it again to have opus decoder and encoder. commit 9ff9335c2b024f4c49f20c9ddb8066dd8a661f45 Author: Mart Raudsepp <leio@gentoo.org> Date: Sun Sep 25 22:29:08 2016 +0300 media-plugins/gst-plugins-opus: Properly split again ... instead of building as part of gst-plugins-base[opus]. This makes gst-plugins-opus a split of -base instead of -bad as it was moved from -base to -bad with some leftovers in -bad. The ext/opus/ leftover part in gst-plugins-bad is not necessary for anything and we can safely not package that at all. This should give a nicer upgrade path for stable opus plugin users. Gentoo-bug: 589440 |