Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 589146

Summary: dev-db/oracle-instantclient-* unify package structure moving into dev-db/oracle-instantclient:SLOT
Product: Gentoo Linux Reporter: Sergey S. Starikoff <Ikonta>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: enhancement CC: jstein, sam
Priority: Low Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/23687
Whiteboard:
Package list:
Runtime testing required: ---

Description Sergey S. Starikoff 2016-07-19 11:48:56 UTC
Different packaging for different versions of the same package (Oracle database instantclient) is a wrong thing.

Please, reconfigure legacy Oracle 10 and 11 clients (dev-db/oracle-instantclient-*) in new slotted and use-handled style like dev-db/oracle-instantclient:0/12.1
Comment 1 Jonas Stein gentoo-dev 2016-07-19 13:26:15 UTC
To the best of my knowledge different packaging is not forbidden and is sometimes easier to maintain.
Comment 2 Sergey S. Starikoff 2017-10-25 10:50:13 UTC
(In reply to Jonas Stein from comment #1)
> To the best of my knowledge different packaging is not forbidden and is
> sometimes easier to maintain.

Could you provide an example how to describe Oracle client application dependencies, when it could be built both with Oracle 11 client and Oracle 12 client?
And they are packaged in different way.
Comment 3 Michael Haubenwallner (RETIRED) gentoo-dev 2017-12-13 12:18:55 UTC
(In reply to Sergey S. Starikoff from comment #2)
> Could you provide an example how to describe Oracle client application
> dependencies, when it could be built both with Oracle 11 client and Oracle
> 12 client?
> And they are packaged in different way.

There is the OR operator in dependencies:
RDEPEND="|| (
 dev-db/oracle-instantclient
 dev-db/oracle-instantclient-basic
)"
and for specific subparts, e.g. odbc:
RDEPEND="||
 dev-db/oracle-instantclient[odbc]
 dev-db/oracle-instantclient-odbc
)"

Nevertheless: Do you have a specific need for the old 10 and 11 Client versions, given that even the 12 Client version should be able to connect to 10 and 11 Server versions?

Otherwise I would like to get rid of the 10 and 11 Client versions, keeping the redirecting oracle-instantclient-basic-12.ebuild during the migration only.
Comment 4 Larry the Git Cow gentoo-dev 2018-07-09 14:58:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5719cacb8b4d4f2b0d40e92e667a7c940de1b319

commit 5719cacb8b4d4f2b0d40e92e667a7c940de1b319
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2018-07-09 14:52:29 +0000
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: 2018-07-09 14:57:33 +0000

    dev-db/oracle-instantclient-basic: cleanup old
    
    Bug: https://bugs.gentoo.org/589146
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-db/oracle-instantclient-basic/Manifest         |   8 -
 .../files/11.2.0.3-makefile.patch                  |  57 ------
 .../files/tnsnames.ora.sample                      |  93 ----------
 .../oracle-instantclient-basic-11.2.0.3.ebuild     | 197 --------------------
 .../oracle-instantclient-basic-11.2.0.4.ebuild     | 199 ---------------------
 5 files changed, 554 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81f2b535a3defef03329a38d529b28d480a78d9a

commit 81f2b535a3defef03329a38d529b28d480a78d9a
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2018-07-09 14:51:59 +0000
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: 2018-07-09 14:57:33 +0000

    dev-db/oracle-instantclient-sqlplus: cleanup old
    
    Bug: https://bugs.gentoo.org/589146
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-db/oracle-instantclient-sqlplus/Manifest       |  4 --
 ...oracle-instantclient-sqlplus-11.2.0.3-r1.ebuild | 71 ----------------------
 .../oracle-instantclient-sqlplus-11.2.0.3.ebuild   | 69 ---------------------
 .../oracle-instantclient-sqlplus-11.2.0.4.ebuild   | 71 ----------------------
 4 files changed, 215 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99e250cc469bb522c3724e3fd3104258cfd96317

commit 99e250cc469bb522c3724e3fd3104258cfd96317
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2018-07-09 14:51:39 +0000
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: 2018-07-09 14:57:32 +0000

    dev-db/oracle-instantclient-odbc: cleanup old
    
    Bug: https://bugs.gentoo.org/589146
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-db/oracle-instantclient-odbc/Manifest          |   4 -
 .../oracle-instantclient-odbc-11.2.0.3.ebuild      | 116 ---------------------
 .../oracle-instantclient-odbc-11.2.0.4.ebuild      |  96 -----------------
 3 files changed, 216 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fdaa33ab2b75287eb555cc5a98d5b2cc94f7ee32

commit fdaa33ab2b75287eb555cc5a98d5b2cc94f7ee32
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2018-07-09 14:50:56 +0000
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: 2018-07-09 14:57:32 +0000

    dev-db/oracle-instantclient-jdbc: cleanup old
    
    Bug: https://bugs.gentoo.org/589146
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-db/oracle-instantclient-jdbc/Manifest          |   4 -
 .../oracle-instantclient-jdbc-11.2.0.3.ebuild      | 109 ---------------------
 .../oracle-instantclient-jdbc-11.2.0.4.ebuild      |  92 -----------------
 3 files changed, 205 deletions(-)
Comment 5 Michael Haubenwallner (RETIRED) gentoo-dev 2018-07-10 06:13:12 UTC
(In reply to Larry the Git Cow from comment #4)
> The bug has been referenced in the following commit(s):

Uhm, had to revert these commits - forgot that there are stable keywords even with fetch restriction.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-11 17:47:54 UTC
Ping. Any update on this? It would let us clean up EAPI 4 ebuilds (dev-db/oracle-instantclient*).
Comment 7 Michael Haubenwallner (RETIRED) gentoo-dev 2020-09-25 15:14:23 UTC
The prerequisite here is to stabilize the newer version in the single package, followed by the migration of revdeps to the new naming scheme.

In the attempt (just before my holidays) to file the stabilization request I realized they updated their license, which _may_ allow to drop the fetch restriction now, and then ran out of time additionally required to figure out details about how to deal with that license update.
Comment 8 Larry the Git Cow gentoo-dev 2022-01-15 21:51:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c707c93b6a199d93d787b1e003d9ad1ef5786ad

commit 0c707c93b6a199d93d787b1e003d9ad1ef5786ad
Author:     Marco Genasci <fedeliallalinea@gmail.com>
AuthorDate: 2022-01-07 15:13:07 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-01-15 21:50:24 +0000

    dev-db/oracle-instantclient-*: removed old packages
    
    Please use unified package dev-db/oracle-instantclient
    
    Closes: https://bugs.gentoo.org/589146
    Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-db/oracle-instantclient-basic/metadata.xml        |  5 -----
 .../oracle-instantclient-basic-12.ebuild              | 16 ----------------
 dev-db/oracle-instantclient-jdbc/metadata.xml         |  5 -----
 .../oracle-instantclient-jdbc-12.ebuild               | 19 -------------------
 dev-db/oracle-instantclient-odbc/metadata.xml         |  5 -----
 .../oracle-instantclient-odbc-12.ebuild               | 19 -------------------
 dev-db/oracle-instantclient-sqlplus/metadata.xml      |  5 -----
 .../oracle-instantclient-sqlplus-12.ebuild            | 19 -------------------
 8 files changed, 93 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0af25712cb38fb03c45227f229c77720e17e1cad

commit 0af25712cb38fb03c45227f229c77720e17e1cad
Author:     Marco Genasci <fedeliallalinea@gmail.com>
AuthorDate: 2022-01-09 12:04:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-01-15 21:50:58 +0000

    profiles: Mask dev-db/oracle-instantclient-* for removal
    
    Bug: https://bugs.gentoo.org/589146
    Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/23687
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Comment 9 Larry the Git Cow gentoo-dev 2022-01-15 21:52:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=232ae4ff8af6bfad43a8b9fe9e681b03337caccd

commit 232ae4ff8af6bfad43a8b9fe9e681b03337caccd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-01-15 21:51:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-01-15 21:52:07 +0000

    Revert "dev-db/oracle-instantclient-*: removed old packages"
    
    This reverts commit 0c707c93b6a199d93d787b1e003d9ad1ef5786ad.
    
    Needs last-rites.
    
    Bug: https://bugs.gentoo.org/589146
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-db/oracle-instantclient-basic/metadata.xml        |  5 +++++
 .../oracle-instantclient-basic-12.ebuild              | 16 ++++++++++++++++
 dev-db/oracle-instantclient-jdbc/metadata.xml         |  5 +++++
 .../oracle-instantclient-jdbc-12.ebuild               | 19 +++++++++++++++++++
 dev-db/oracle-instantclient-odbc/metadata.xml         |  5 +++++
 .../oracle-instantclient-odbc-12.ebuild               | 19 +++++++++++++++++++
 dev-db/oracle-instantclient-sqlplus/metadata.xml      |  5 +++++
 .../oracle-instantclient-sqlplus-12.ebuild            | 19 +++++++++++++++++++
 8 files changed, 93 insertions(+)