| Summary: | dev-util/calltree-0.9.7 won't work with /dev-util/valgrind-2.1.2 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Priit Laes (IRC: plaes) <plaes> |
| Component: | Current packages | Assignee: | Caleb Tennis (RETIRED) <caleb> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | bartek, f5d8fd51ed1e804c9e8d0357e8614e0493b06e96, halcy0n, lu_zero, robbat2 |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
calltree-0.9.7_configure.patch
calltree-0.9.7-r1.ebuild |
||
|
Description
Priit Laes (IRC: plaes)
2004-07-30 05:02:26 UTC
This package seems to be renamed to callgrind, but this package is only available in CVS. No release so far... Seems like Valgrind's internal skin code has also changed a bit. CVS version already supports it... *** Bug 59149 has been marked as a duplicate of this bug. *** check: http://kcachegrind.sourceforge.net/cgi-bin/show.cgi/KcacheGrindVg212 Patch for Calltree 0.9.7 to run with Valgrind 2.1.2 Apply the follow patch (or modify manually the one number from 5 to 6 in configure.in): --- configure.in.old 2004-08-04 11:54:55.211422776 +0200 +++ configure.in 2004-08-04 11:55:52.811666208 +0200 @@ -60,7 +60,7 @@ CFLAGS="-I $VG_INCDIR" AC_TRY_RUN([ #include "vg_skin.h" -int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 5) ? 1:0; } +int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 6) ? 1:0; } ], [ AC_MSG_RESULT([Yes]) ], [ Created attachment 36792 [details, diff]
calltree-0.9.7_configure.patch
Created attachment 36793 [details]
calltree-0.9.7-r1.ebuild
tested the ebuild, doing fine for me.
calltree compiles and works just fine
Personally I'd modifiy the configure directly rather than regenerating it... --- calltree-0.9.7.ebuild 2004-06-25 03:39:16.000000000 +0100 +++ calltree-0.9.7-r1.ebuild 2004-08-09 22:03:47.672270650 +0100 @@ -2,6 +2,8 @@ # Distributed under the terms of the GNU General Public License v2 # $Header: /var/cvsroot/gentoo-x86/dev-util/calltree/calltree-0.9.7.ebuild,v 1.2 2004/06/25 02:21:53 agriffis Exp $ +inherit eutils + DESCRIPTION="A plugin for cachegrind that adds call-graph profiling, needed by kcachegrind" HOMEPAGE="http://kcachegrind.sourceforge.net/" SRC_URI="http://kcachegrind.sourceforge.net/${P}.tar.gz" @@ -13,6 +15,12 @@ DEPEND=">=dev-util/valgrind-2.1.0" +src_unpack() { + unpack ${P}.tar.gz + + epatch ${FILESDIR}/calltree-0.9.7-configure.patch +} + src_install() { einstall || die rm -rf ${D}/usr/share/doc/valgrind And then add this as files/calltree-0.9.7-configure.patch --- calltree-0.9.7/configure 2004-08-09 22:08:53.510438433 +0100 +++ calltree-0.9.7/configure 2004-08-09 22:09:06.152269674 +0100 @@ -3279,7 +3279,7 @@ /* end confdefs.h. */ #include "vg_skin.h" -int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 5) ? 1:0; } +int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 6) ? 1:0; } _ACEOF rm -f conftest$ac_exeext A fairly academic difference though ;-) i just put my own fix in cvs, and only found this afterwards. either way, it's done now. DEPEND=">=dev-util/valgrind-2.1.0 <dev-util/valgrind-2.1.2" sorry, but this is no fix.. this is just.. well.. I'll keep this for myself valgrind 2.1.2 is a "bugfix-release". what use is it rejecting to work with this version if just a tiny fix in the configure script is needed so calltree will accept it... ? I put that in place and set up 0.9.7-r1 with the fix for users with valgrind-2.1.2. |
