| Summary: | net-mail/dbmail - add support for systemd in ebuild | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Edoardo Liverani <eddyx89> |
| Component: | Current packages | Assignee: | Thomas Raschbacher <lordvan> |
| Status: | UNCONFIRMED --- | ||
| Severity: | enhancement | CC: | aklhfex, jstein, net-mail+disabled |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | The patch | ||
(In reply to Edoardo Liverani from comment #0) > Created attachment 440476 [details, diff] [details, diff] > The patch > > Attached patch to add support for systemd units scripts in dbmail > installation. > I don't know if I should add any other dependency for systemd use flag. > Tested on my system and seems to work. > I think the same modifications could be made on dbmail-3.2.2.ebuild Note on the patch: I suspect systemd IUSE is not needed and --enable-systemd should always be passed to install the service files. I think there is a bit more work to do:
- DBMail's dbmail.tmpfiles is for nobody/nobody but Gentoo uses dbmail/dbmail
- For PostgreSQL DBMail units have postgresql.service but Gentoo only has postgresql-${PN}.service
See bug #575930
Also some discussion about not using Type=forking here: https://github.com/pjstevns/dbmail/issues/35 Hopefully --enable-systemd should be optional in future to build with sd_notify: https://github.com/pjstevns/dbmail/commit/c6773f6b5ff6d87513c3759565df1700128c7e42 Almost two years has passed from this report and dbmail ebuild still lacks systemd support. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb2db800978bb3f4e205f0c833666932c9a76cdb commit bb2db800978bb3f4e205f0c833666932c9a76cdb Author: Agostino Sarubbo <ago@gentoo.org> AuthorDate: 2018-04-04 19:31:49 +0000 Commit: Agostino Sarubbo <ago@gentoo.org> CommitDate: 2018-04-04 20:03:29 +0000 net-mail/dbmail: add systemd support, install docs via dodocs, fix DESCRIPTION.toolong. Leave the upstream suggestions to the maintainer judgment Bug: https://bugs.gentoo.org/588690 Package-Manager: Portage-2.3.24, Repoman-2.3.6 net-mail/dbmail/dbmail-3.2.3-r2.ebuild | 135 +++++++++++++++++++++++++++++++++ 1 file changed, 135 insertions(+)} |
Created attachment 440476 [details, diff] The patch Attached patch to add support for systemd units scripts in dbmail installation. I don't know if I should add any other dependency for systemd use flag. Tested on my system and seems to work. I think the same modifications could be made on dbmail-3.2.2.ebuild