Bug 588666

Summary:	app-admin/hddtemp - the update-hddtemp.db script downloads an old version of hddgentoo.db
Product:	Gentoo Linux	Reporter:	Paolo Pedroni <paolo.pedroni>
Component:	Current packages	Assignee:	Amadeusz Żołnowski (RETIRED) <aidecoe>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	hddtemp-fix-588666-574090.patch hddtemp-fix-588666-574090.patch

Description Paolo Pedroni 2016-07-12 09:35:01 UTC

As in summary:

the script downloads the file at <http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-admin/hddtemp/files/hddgentoo.db>, which is outdated and does not contain the drives added in the latest bugs.

It should probably be updated to download from gitweb.gentoo.org.

Comment 1 Paolo Pedroni 2016-07-12 10:34:04 UTC

Created attachment 440436 [details, diff]
hddtemp-fix-588666-574090.patch

Quick and dirty patch to fix current bug, also fixes bug #574090 and removes old.

Comment 2 Paolo Pedroni 2016-07-12 10:35:35 UTC

Created attachment 440438 [details, diff]
hddtemp-fix-588666-574090.patch

Oops, wrong patch version. Current one is right.

Comment 3 Paolo Pedroni 2016-07-12 10:37:41 UTC

Would you rather have a github PR?

Comment 4 Amadeusz Żołnowski (RETIRED) gentoo-dev

2016-07-20 21:16:28 UTC

Thanks! Fixed.

There was no need to have a second version of this script as update-hddtemp.db-1 and therefore there was no need to update ebuild, just bump to force update for users.