| Summary: | app-mobilephone/smssend-3.4 : /.../libskyutils.so: undefined reference to `SSLv3_client_method' | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Michael Orlitzky <mjo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | maintainer-needed, qa, treecleaner |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
app-mobilephone:smssend-3.4:20160708-095655.log
emerge-history.txt environment |
||
|
Description
Toralf Förster
2016-07-08 12:52:57 UTC
Created attachment 440052 [details]
app-mobilephone:smssend-3.4:20160708-095655.log
Created attachment 440054 [details]
emerge-history.txt
Created attachment 440056 [details]
environment
CCing treecleaners (I cannot find upstream ever) commit ac28332d1cba199acaa141111a805ccc942cc1dd Author: Michael Orlitzky <mjo@gentoo.org> Date: Sat Aug 6 20:05:23 2016 -0400 app-mobilephone/smssend: new revision requiring SSLv3 symbols. The build for this was failing on SSLv3_client_method, so now it depends on dev-libs/skyutils[sslv3] which was recently added to guarantee that skylibs will be built against OpenSSL with SSLv3 support. The ebuild was updated to EAPI=6 in the process. Gentoo-Bug: 567554 Gentoo-Bug: 588326 Package-Manager: portage-2.2.28 app-mobilephone/smssend/smssend-3.4-r1.ebuild | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) The fix looks very wrong. The linker output clearly states the SSLv3 reference comes from libskyutils, so it is only libskyutils being built incorrectly. The place for a fix (if any) is there and not in random applications linked to it. (In reply to Michał Górny from comment #6) > The fix looks very wrong. The linker output clearly states the SSLv3 > reference comes from libskyutils, so it is only libskyutils being built > incorrectly. The place for a fix (if any) is there and not in random > applications linked to it. So, drop libressl support from skyutils and require openssl[sslv3] there? No. Fix skyutils properly. The fault lies there, and not in smssend. As the linker tells you: /usr/lib64/libskyutils.so: undefined reference to `SSLv3_client_method' If skyutils[-sslv3] causes this failure, it means that *skyutils is using sslv3 functions nevertheless* and the flag doesn't do anything but output false dependencies. In other words, skyutils[-sslv3] is completely broken and useless, and will cause every package linking against it to fail. And yes, ld does not check valid linkage when creating libraries. It checks it when linking the final executable. (In reply to Michał Górny from comment #8) > No. Fix skyutils properly. The fault lies there, and not in smssend. As the > linker tells you: > > /usr/lib64/libskyutils.so: undefined reference to `SSLv3_client_method' > > If skyutils[-sslv3] causes this failure, it means that *skyutils is using > sslv3 functions nevertheless* and the flag doesn't do anything but output > false dependencies. In other words, skyutils[-sslv3] is completely broken > and useless, and will cause every package linking against it to fail. > Right, that's what I meant -- I'll drop libressl support from skyutils and depend unconditionally on openssl[sslv3] in skyutils. The skyutils[sslv3] flag only forced openssl[sslv3], so at that point I'll drop the sslv3 flag from skyutils. Does it really make sense to keep this old app? sslv3 is insecure and will be dropped also from openssl sooner or later... keeping this without really needing will only delay this work to be done (In reply to Pacho Ramos from comment #10) > Does it really make sense to keep this old app? No, but this fix was easier (irony noted) than it would have been to lastrite the package myself. By all means, open a new treecleaners bug if you want. This is old junk and probably unused, but having it crash looks bad and adds bugs to an already long list. Michał, thanks for pointing out my screwup. commit 8b119a6c8aab5ac6a6b2cb3b79171229be895108 Author: Michael Orlitzky <mjo@gentoo.org> Date: Sun Aug 7 18:26:57 2016 -0400 app-mobilephone/smssend, dev-libs/skyutils: fix SSLv3 support. In commits 790eacc and ac28332, I added an "sslv3" USE flag to dev-libs/skyutils and revisioned app-mobilephone/smssend to depend on it. This fix was insufficient; any other programs linking to libskyutils would suffer the same problem, as Michał Górny pointed out. Two new revisions of the affected packages remove the "sslv3" option for dev-libs/skyutils, and make it depend on openssl[sslv3] when the user asks for SSL support. Note: this required the removal of LibreSSL support on skyutils. The new revision of app-mobilephone/smssend now depends on the fixed revision of skyutils. An additional fix was made, and now smssend depends on skyutils[ssl]. Without SSL support in libskyutils, many SMS providers simply don't work. Gentoo-Bug: 588326 |
