Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 588076

Summary: dev-libs/klibc-2.0.4 USE=-custom-cflags don't respect own default flags
Product: Gentoo Linux Reporter: Denis Kaganovich <mahatma>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal Keywords: NeedPatch
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=103437
https://bugs.gentoo.org/show_bug.cgi?id=496634
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: klibc keep default CFLAGS

Description Denis Kaganovich 2016-07-05 16:36:50 UTC
dev-libs/klibc-2.0.4 USE=-custom-cflags build with CFLAGS (amd64: "-Os -fno-ident -fomit-frame-pointer -mno-sse -falign-functions=1 -falign-jumps=1 -falign-loops=1 -fno-asynchronous-unwind-tables") replaced by "-nostdlib". Resulting code is near +500M.
Comment 1 Denis Kaganovich 2016-07-05 16:41:33 UTC
Created attachment 439798 [details, diff]
klibc keep default CFLAGS
Comment 2 Pacho Ramos gentoo-dev 2016-08-12 13:50:25 UTC
do you want to proxy maintain this?
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 3 Nikita Zlobin 2017-11-28 13:24:51 UTC
Hello. It seems, problem is in ebuild.
Just look to these emake args:
        $(use custom-cflags || echo SKIP_)HOSTCFLAGS="${CFLAGS}" \
        $(use custom-cflags || echo SKIP_)HOSTLDFLAGS="${LDFLAGS}" \
        $(use custom-cflags || echo SKIP_)KLIBCOPTFLAGS="${CFLAGS}" \

I grepped through sorces with this:
# grep -nR -e 'SKIP_' /var/calculate/tmp/portage/dev-libs/klibc-2.0.4-r3/work/klibc-2.0.4 | grep Kbuild

...and got empty output.

While e.g. HOSTCFLAGS is found only in Makefiles across all sources tree, but not more.
Comment 4 Nikita Zlobin 2017-11-28 13:28:45 UTC
So, up to current klibc version - custom-cflags USE flag was simply pointless dumb. Though i'm not exprt in that, imho fact, that some kernel kinds allow to configure CPU type to native, thus building with -march=native, would be useful to enable such feature for klibc too.
Comment 5 Nikita Zlobin 2017-11-28 21:09:10 UTC
I'm sorry for unintentional desinfo.
Did not notice own mistake, until attempt to manually run all commands from src_compile in order to reproduce bug with misfound havesyscall.h.
Comment 6 Larry the Git Cow gentoo-dev 2021-04-14 16:12:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3df1935ebf6359efe481e27a7e3c91051e15a95f

commit 3df1935ebf6359efe481e27a7e3c91051e15a95f
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2021-04-14 00:07:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-14 15:29:58 +0000

    dev-libs/klibc: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/722626
    Closes: https://bugs.gentoo.org/729876
    Closes: https://bugs.gentoo.org/496634
    Closes: https://bugs.gentoo.org/722960
    Closes: https://bugs.gentoo.org/685036
    Closes: https://bugs.gentoo.org/588076
    Closes: https://bugs.gentoo.org/585618
    Closes: https://bugs.gentoo.org/623404
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/klibc/Manifest                            |   3 -
 .../klibc/files/klibc-1.4.11-interp-flags.patch    |  13 -
 .../klibc/files/klibc-1.5.7-strip-fix-dash-s.patch |  12 -
 dev-libs/klibc/files/klibc-2.0.2-mkfifo.patch      |  15 -
 dev-libs/klibc/files/klibc-2.0.3-kernel-uapi.patch |  88 ------
 dev-libs/klibc/files/klibc.m4                      |  94 ------
 dev-libs/klibc/klibc-2.0.4-r3.ebuild               | 320 ---------------------
 dev-libs/klibc/metadata.xml                        |   5 -
 profiles/package.mask                              |   5 -
 9 files changed, 555 deletions(-)