Summary: | sys-apps/portage: glsa-check needs a "bad" exit code on affection. | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Bandie Canis <bandie> |
Component: | Enhancement/Feature Requests | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | Keywords: | InVCS |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 691278 | ||
Attachments: |
glsa-check patch for adding a sys.exit(6) in case of affection
man page: EXIT VALUES section added glsa-check patch for adding a sys.exit(6) in case of affection |
We should add an "EXIT VALUES" section to man/glsa-check.1, like rsync's man page has. Created attachment 439606 [details, diff]
man page: EXIT VALUES section added
Created attachment 439608 [details, diff]
glsa-check patch for adding a sys.exit(6) in case of affection
looks good, thank you Bump - can you please add this patch or equivalent to one of the next portage releases? The patches LGTM. Bump. glsa-check is included with >=sys-apps/portage-2.3.72 (bug 463952). The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=712e2b3fe88fd597914ddf449849b195c15fbcf6 commit 712e2b3fe88fd597914ddf449849b195c15fbcf6 Author: Aaron Bauman <bman@gentoo.org> AuthorDate: 2019-08-30 19:29:00 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2019-08-31 03:40:20 +0000 glsa-check: add man page exit values Bug: https://bugs.gentoo.org/587930 Reported-by: Bandie Yip Kojote <bandie@ttygap.net> Signed-off-by: Aaron Bauman <bman@gentoo.org> Signed-off-by: Zac Medico <zmedico@gentoo.org> man/glsa-check.1 | 12 ++++++++++++ 1 file changed, 12 insertions(+) https://gitweb.gentoo.org/proj/portage.git/commit/?id=4d9c10704b2eaf6cd7467ff0929a94e64429bfa6 commit 4d9c10704b2eaf6cd7467ff0929a94e64429bfa6 Author: Aaron Bauman <bman@gentoo.org> AuthorDate: 2019-08-30 19:18:56 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2019-08-31 03:40:06 +0000 glsa-check: add exit code for affected GLSAs Bug: https://bugs.gentoo.org/587930 Reported-by: Bandie Yip Kojote <bandie@ttygap.net> Signed-off-by: Aaron Bauman <bman@gentoo.org> Signed-off-by: Zac Medico <zmedico@gentoo.org> bin/glsa-check | 1 + 1 file changed, 1 insertion(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05d4de36535c74df5e27784886a7de8d0d8afddb commit 05d4de36535c74df5e27784886a7de8d0d8afddb Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2019-08-31 06:13:47 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2019-08-31 06:21:36 +0000 sys-apps/portage: Bump to version 2.3.74 #587930 glsa-check: add exit code for affected GLSAs #688902 Add FEATURES=pkgdir-index-trusted #690758 Use RTNETLINK to configure the loopback interface #692872 glsa-check: forward port --quiet option from gentoolkit #693026 rsync: proxychains compatibility #693088 glsa-check: forward port remaining changes from gentoolkit #693096 emerge: deprecate --changelog option Bug: https://bugs.gentoo.org/691278 Bug: https://bugs.gentoo.org/587930 Bug: https://bugs.gentoo.org/688902 Bug: https://bugs.gentoo.org/690758 Bug: https://bugs.gentoo.org/692872 Bug: https://bugs.gentoo.org/693026 Bug: https://bugs.gentoo.org/693088 Bug: https://bugs.gentoo.org/693096 Package-Manager: Portage-2.3.74, Repoman-2.3.17 Signed-off-by: Zac Medico <zmedico@gentoo.org> sys-apps/portage/Manifest | 1 + sys-apps/portage/portage-2.3.74.ebuild | 261 +++++++++++++++++++++++++++++++++ 2 files changed, 262 insertions(+) |
Created attachment 439602 [details] glsa-check patch for adding a sys.exit(6) in case of affection When I was wroting a bash script with glsa-check I saw that it wouldn't return a non-zero exit code if glsa-check reports an affection. Here's a patch which makes a sys.exit(6) in case of affection.