Bug 587048

Summary:	net-p2p/ktorrent-5.0.1 fails to compile with KSharedConfigPtr has not been declared
Product:	Gentoo Linux	Reporter:	Jonathan Scruggs (RETIRED) <dracwyrm>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jlp.bugs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	KSharedConfig-Compile-Fix.patch

Description Jonathan Scruggs (RETIRED) gentoo-dev

2016-06-25 15:25:47 UTC

Created attachment 438768 [details, diff]
KSharedConfig-Compile-Fix.patch

When trying to compile said version of KTorrent I run into this error:
In file included from /var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.cpp:21:0:
/var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.h:46:24: error: ‘KSharedConfigPtr’ has not been declared
         void loadState(KSharedConfigPtr cfg);
                        ^
/var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.h:51:24: error: ‘KSharedConfigPtr’ has not been declared
         void saveState(KSharedConfigPtr cfg);
                        ^
/var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.cpp:76:10: error: prototype for ‘void kt::PasteDialog::loadState(KSharedConfigPtr)’ does not match any in class ‘kt::PasteDialog’
     void PasteDialog::loadState(KSharedConfigPtr cfg)
          ^
In file included from /var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.cpp:21:0:
/var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.h:46:14: error: candidate is: void kt::PasteDialog::loadState(int)
         void loadState(KSharedConfigPtr cfg);
              ^
/var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.cpp:83:10: error: prototype for ‘void kt::PasteDialog::saveState(KSharedConfigPtr)’ does not match any in class ‘kt::PasteDialog’
     void PasteDialog::saveState(KSharedConfigPtr cfg)
          ^
In file included from /var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.cpp:21:0:
/var/tmp/portage/net-p2p/ktorrent-5.0.1/work/ktorrent-5.0.1/ktorrent/dialogs/pastedialog.h:51:14: error: candidate is: void kt::PasteDialog::saveState(int)
         void saveState(KSharedConfigPtr cfg);
              ^
make[2]: *** [ktorrent/CMakeFiles/ktorrent_app.dir/build.make:543: ktorrent/CMakeFiles/ktorrent_app.dir/dialogs/pastedialog.cpp.o] Error 1


The issue is known upstream and there is already a patch in master:
https://github.com/KDE/ktorrent/commit/ac8eb6b360fbaa2588ec523bb81c380289586db6

I'm uploading a copy of that patch. I have successfully compiled KTorrent with it.

Hope you find it useful. (you may want to rename it better than what I did.)

Kind regards,
Jon

Comment 1 Michael Palimaka (kensington) gentoo-dev

2016-06-26 18:08:03 UTC

Thanks, fixed in git.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2ec04368e585abd931ba9e5f18bc16b9ef67e45