Summary: | sys-apps/ufiformat: UFI USB floppy disk formatter | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jocelyn Mayer <l_indien> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | CONFIRMED --- | ||
Severity: | enhancement | CC: | gokturk, proxy-maint |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
sys-apps/ufiformat version 0.9.9 ebuild
New fixed version of ufiformat-0.9.9 ebuild Updated ebuild for ufiformat-0.9.9 |
Description
Jocelyn Mayer
2016-06-08 09:11:25 UTC
Created attachment 436852 [details]
sys-apps/ufiformat version 0.9.9 ebuild
Here is the ebuild used to merge sys-apps/ufiformat and use it, tested on amd64, ppc and ppc64 machines.
Hello, would you be willing to maintain this package through Proxy Maintainers project? https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers Hi, I see no objection doing this package maintenance. I guess this won't be a huge task as the protocol implementation is quite complete. I'll be able to get involved starting from 01/2017. Hi, I'd like to make a few remarks about your submission. They should be addressed before we can proceed further. For future submissions, you don't have to tarball the whole directory, just attaching the ebuild file is enough. Now for the actual submission: - ${P} and ${MY_P} are the same thing, so ${MY_P} should be removed - The copyright year on line 1 should reflect 2017 - The license should be GPL-2+, becuse it says GPL-2 or later in the source - Remove $Header - Inheriting eutils isn't necessary because this ebuild isn't utilizing any of its functionality. - KEYWORDS must be fixed. You should only include the architectures that you have successfully tested this package on. I'm guessing that will be amd64 for you. Because this package will be included as "unstable", you need "~amd64" in KEYWORDS. I have an x86 machine that I can test this with if needed. - You are possibly missing a build time dependency on sys-kernel/linux-headers due to '#include <linux/major.h>' in ufi_detect.c. - sys-fs/e2fsprogs is a runtime dependency and should be in RDEPEND: $ scanelf -n ufiformat TYPE NEEDED FILE ET_EXEC libext2fs.so.2,libc.so.6 ufiformat - '|| die' after emake isn't required in EAPI 6, emake calls it internally on failure Thank you for your interest, Created attachment 467288 [details]
New fixed version of ufiformat-0.9.9 ebuild
New version of the ufiformat-0.9.9 ebuild with:
* simplification: remove unneeded MY_P variable
* simplification: remove unneeded eutils inheritance
* simplification: remove unneeded src_install function
* fix copyright year
* fix package license
* fix dependencies
Thanks for the tips ! I tried to apply all your comments and simplify the ebuild (for example, remove the unneeded src_install function). Note: this package has been succesfully tested with many floppy disks of different format sizes on the three listed architectures, ie amd64, ppc and ppc64. I removed x86 from the list, as it's currently untested. @Jocelyn Mayer: I'm sorry that this bug has never received a reply. I am not a member of proxy-maint anymore but they might have been under the impression that I will follow through with the review. If you are still interested, please contact them again. Created attachment 558316 [details] Updated ebuild for ufiformat-0.9.9 I've just found this bug, because I wanted to make an Iomega floppy drive work. The upstream package has been moved onto github because geocities.jp is closing. New ebuild which uses the github URL as source attached, based on the last submission here. Tested on amd64 and x86 machines with an iomega (Citizen Watch according to lsusb) drive. Signed-off-by: Richard Ash <richard@audacityteam.org> |