Bug 584554 – games-misc/fortune-mod-slackware-1.15 : games-misc/fortune-mod-slackware-1.15 : * These fortunes have offensive content. Enable offensive USE Flag

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Toralf Förster 2016-05-30 18:05:08 UTC]

 * USE:        abi_x86_64 amd64 elibc_glibc kernel_linux userland_GNU
 * FEATURES:   preserve-libs sandbox userpriv usersandbox
 * These fortunes have offensive content. Enable offensive USE Flag
 * ex: USE="offensive" emerge fortune-mod-slackware
 *  or add to package.use file: games-misc/fortune-mod-slackware offensive
 * ERROR: games-misc/fortune-mod-slackware-1.15::gentoo failed (setup phase):


$ cat emerge-info.txt
  -----------------------------------------------------------------

  This is an unstable amd64 chroot image (named amd64-gnome-systemd-unstable_20160522-162705) at a hardened host acting as a tinderbox.

  -----------------------------------------------------------------

  make.conf: USE="mmx sse sse2 pax_kernel xtpax -cdinstall -oci8 -bindist alsa apache apache2 avx2 compat dbus dot ecc ftp gles2 gpg gui haptic ldap libkms logrotate mikmod -mssql nss opencv scrypt sdl semantic-desktop -sqlite sse4_1 ssh ssh-askpass ssl -system-ffmpeg -system-jpeg system-sqlite -tk uml vorbis xkb postgres"

  -----------------------------------------------------------------

Portage 2.3.0_rc1 (python 3.4.3-final-0, default/linux/amd64/13.0/desktop/gnome/systemd, gcc-5.3.0, glibc-2.23-r2, 4.5.5-hardened-r1 x86_64)
=================================================================
System uname: Linux-4.5.5-hardened-r1-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16157888 total,   2865080 free
KiB Swap:   16777212 total,  16718284 free
Timestamp of repository gentoo: Sat, 28 May 2016 16:04:32 +0000
sh bash 4.3_p42-r2
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
ccache version 3.2.5 [disabled]
app-shells/bash:          4.3_p42-r2::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.0::gentoo
dev-lang/python:          2.7.11-r2::gentoo, 3.4.3-r7::gentoo, 3.5.1-r2::gentoo
dev-util/ccache:          3.2.5::gentoo
dev-util/cmake:           3.5.2-r1::gentoo
dev-util/pkgconfig:       0.29.1::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.21::gentoo
sys-apps/sandbox:         2.10-r2::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r2::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.11.6-r2::gentoo, 1.12.6-r1::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            5.3.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.2-r1::gentoo
sys-kernel/linux-headers: 4.6::gentoo (virtual/os-headers)
sys-libs/glibc:           2.23-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: 1

local
    location: /usr/local/portage
    masters: gentoo
    priority: 2

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/omega.conf /etc/stunnel/stunnel.conf /opt/openfire/resources/security/ /usr/share/config /usr/share/maven-bin-3.3/conf /var/lib/i2pd/certificates"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/tmp/distfiles"
EMERGE_DEFAULT_OPTS="--verbose-conflicts --color=n --nospinner --tree --quiet-build"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox parallel-fetch preserve-libs protect-owned sandbox sfperms strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gor.bytemark.co.uk/gentoo/ rsync://ftp.snt.utwente.nl/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 apache apache2 avx2 berkdb bluetooth branding bzip2 cairo cdda cdr cli colord compat cracklib crypt cups cxx dbus dot dri dts dvd dvdr ecc eds emboss encode evo exif fam firefox flac fortran ftp gdbm gif glamor gles2 gnome gnome-keyring gnome-online-accounts gpg gpm gstreamer gtk gui haptic iconv introspection ipv6 jpeg lcms ldap libkms libnotify libsecret logrotate mad mikmod mmx mmxext mng modules mp3 mp4 mpeg multilib nautilus ncurses nls nptl nss ogg opencv opengl openmp pam pango pax_kernel pcre pdf png policykit postgres ppds pulseaudio qt3support qt4 readline scrypt sdl seccomp semantic-desktop session spell sse sse2 sse4_1 ssh ssh-askpass ssl startup-notification svg system-sqlite systemd tcpd tiff tracker truetype udev udisks uml unicode upower usb vorbis wxwidgets x264 xattr xcb xkb xml xtpax xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Toralf Förster 2016-05-30 18:05:11 UTC]

Created attachment 435748 [details]
die.env

[Comment 2 Toralf Förster 2016-05-30 18:05:13 UTC]

Created attachment 435750 [details]
emerge-history.txt

[Comment 3 Toralf Förster 2016-05-30 18:05:16 UTC]

Created attachment 435752 [details]
games-misc:fortune-mod-slackware-1.15:20160528-190313.log

[Comment 4 Mr. Bones. (RETIRED) 2016-05-30 18:23:44 UTC]

You're missing the expected results part of the bug report.  It looks to me like the ebuild is behaving as intended.

[Comment 5 Toralf Förster 2016-05-30 18:37:38 UTC]

(In reply to Mr. Bones. from comment #4)
I'm unsure if I already asked this in the past but isn't there a way for the ebuild to simply depend on that USE flag then ?

[Comment 6 Mr. Bones. (RETIRED) 2016-05-30 19:14:15 UTC]

If you add games-misc/fortune-mod-slackware[offensive] to RDEPEND then you get:

USE=-offensive emerge --oneshot -vp games-misc/fortune-mod-slackware

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] games-misc/fortune-mod-slackware-1.15::gentoo  USE="offensive" 120 KiB

Total: 1 package (1 new), Size of downloads: 120 KiB

The following USE changes are necessary to proceed:
 (see "package.use" in the portage(5) man page for more details)
# required by games-misc/fortune-mod-slackware (argument)
>=games-misc/fortune-mod-slackware-1.15 offensive

But there's no message telling why.  I guess you could assume but the way the ebuild is now gives a message explaining why the use flag needs to be turned on which seems like a better user experience.

[Comment 7 Toralf Förster 2016-05-31 17:22:34 UTC]

I do agree. portage should have a feature, that in case of a missing/wrong USE flag an ebuild function like "ehint()" should - if defined - be called.
Maybe an idea for an improvement of portage.

But the current ebuild hides the information about a mandatory USE flag dependency to portage. Therefore portage doesn't have a chance to calculate a correct dependency tree, right ?

[Comment 8 Mr. Bones. (RETIRED) 2016-06-01 01:35:06 UTC]

I think we're close to as good as we can get without a portage feature and frankly this is such an edge case that I'm not even sure it's worth it. "calculate a correct dependency tree" is great but it's either that or a more informative message for the user right now and I'd rather have a better message.
I think using pkg_pretend is a bit of an improvement since it happens earlier but I'm not sure it makes that much practical difference.

[Comment 9 Pacho Ramos 2018-02-28 15:30:29 UTC]

I don't think having this dieying by default is good at all.

If you still want to keep "offensive" USE flag to warn people about this being "offensive" I would use.force enable it... anyway...  I would simply remove the USE flag completely (and maybe warn about offensive content in the DESCRIPTION) and show a warning

[Comment 10 Ulrich Müller 2018-03-01 01:04:58 UTC]

(In reply to Pacho Ramos from comment #9)
> I don't think having this dieying by default is good at all.

From a QA point of view it is fine if an ebuild dies in pkg_pretend or pkg_setup when there are unmet requirements. I'd suggest moving that test to pretend, so it will fail as early as possible.


(In reply to Toralf Förster from comment #7)
> But the current ebuild hides the information about a mandatory USE flag
> dependency to portage. Therefore portage doesn't have a chance to calculate
> a correct dependency tree, right ?

Theoretically, one could also add REQUIRED_USE="offensive" to the ebuild, but it would lose the message that currently informs the user.

[Comment 11 Michał Górny 2020-03-04 16:44:49 UTC]

Package removed.