Bug 584352 – =x11-libs/libva-vdpau-driver-0.7.4-r3: missing #include <sys/time.h> in src/util.c

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Anthony Basile 2016-05-27 18:27:47 UTC]

This is an upstream bug which I'm reporting here for completeness.

src/util.c defines `struct timeval t;` around line 76, but does not include <sys/time.h> as required by POSIX [1].  This is okay with glibc (because of how the headers stack), but not with other libcs, like musl.  It leads to a compile time error.  This is easily fixed with

--- src/util.c.orig	2016-05-27 18:23:49.830943995 +0000
+++ src/utils.c	2016-05-27 18:23:39.534238312 +0000
@@ -21,6 +21,7 @@
 #include "sysdeps.h"
 #include "utils.h"
 #include <time.h>
+#include <sys/time.h>
 #include <errno.h>
 
 #define DEBUG 1


Ref.

[1] http://pubs.opengroup.org/onlinepubs/007908775/xsh/systime.h.html

[Comment 1 Anthony Basile 2016-05-29 16:25:16 UTC]

Patch sent upstream at https://bugs.freedesktop.org/show_bug.cgi?id=96268

[Comment 2 Alexis Ballier 2016-12-29 15:11:27 UTC]

from what i see on the upstream bug, feel free to apply it to portage tree

[Comment 3 Larry the Git Cow 2022-10-05 21:17:51 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fe906d184b33071f7a9b071c934ae30314a6874

commit 5fe906d184b33071f7a9b071c934ae30314a6874
Author:     Matt Turner <[e-mail]>
AuthorDate: 2022-10-05 16:10:57 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2022-10-05 21:17:26 +0000

    profiles: Mask x11-libs/libva-vdpau-driver for removal
    
    Bug: https://bugs.gentoo.org/584352
    Bug: https://bugs.gentoo.org/833102
    Bug: https://bugs.gentoo.org/852728
    Bug: https://bugs.gentoo.org/866557
    Bug: https://bugs.gentoo.org/875278
    Signed-off-by: Matt Turner <[e-mail]>

 profiles/package.mask | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

[Comment 4 Larry the Git Cow 2022-10-05 21:18:59 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ca15677f7e919a2c9030e01f4e4bb2c5a566e08

commit 4ca15677f7e919a2c9030e01f4e4bb2c5a566e08
Author:     Matt Turner <[e-mail]>
AuthorDate: 2022-10-05 16:10:57 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2022-10-05 21:18:51 +0000

    profiles: Mask x11-libs/libva-vdpau-driver for removal
    
    Bug: https://bugs.gentoo.org/584352
    Bug: https://bugs.gentoo.org/833102
    Bug: https://bugs.gentoo.org/852728
    Bug: https://bugs.gentoo.org/866557
    Bug: https://bugs.gentoo.org/875278
    Signed-off-by: Matt Turner <[e-mail]>

 profiles/package.mask | 7 +++++++
 1 file changed, 7 insertions(+)

[Comment 5 Larry the Git Cow 2022-11-01 09:24:34 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=69f9b541579a2462e5b6552fd97bdc21f7610583

commit 69f9b541579a2462e5b6552fd97bdc21f7610583
Author:     Matt Turner <[e-mail]>
AuthorDate: 2022-11-01 09:21:20 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2022-11-01 09:24:27 +0000

    x11-libs/libva-vdpau-driver: Delete
    
    Closes: https://bugs.gentoo.org/584352
    Closes: https://bugs.gentoo.org/833102
    Closes: https://bugs.gentoo.org/852728
    Closes: https://bugs.gentoo.org/866557
    Closes: https://bugs.gentoo.org/875278
    Signed-off-by: Matt Turner <[e-mail]>

 profiles/package.mask                              |  7 ----
 x11-libs/libva-vdpau-driver/Manifest               |  1 -
 ...vdpau-driver-0.7.4-VAEncH264VUIBufferType.patch | 29 -------------
 ...pau-driver-0.7.4-glext-missing-definition.patch | 16 --------
 ...au-driver-0.7.4-include-linux-videodev2.h.patch | 25 -----------
 .../libva-vdpau-driver-0.7.4-libvdpau-0.8.patch    | 13 ------
 .../libva-vdpau-driver-0.7.4-sigfpe-crash.patch    | 21 ----------
 .../libva-vdpau-driver-0.7.4-r5.ebuild             | 48 ----------------------
 x11-libs/libva-vdpau-driver/metadata.xml           | 12 ------
 9 files changed, 172 deletions(-)