Bug 584330

Summary:	dev-libs/libgpg-error: Use EXEEXT and -no-undefined flag even on Unix.
Product:	Gentoo Linux	Reporter:	Michael Haubenwallner (RETIRED) <haubi>
Component:	[OLD] Library	Assignee:	Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alonbl, haubi, k_f, mgorny
Priority:	Normal	Keywords:	PATCH, UPSTREAM
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://lists.gnupg.org/pipermail/gnupg-devel/2017-March/032671.html
See Also:	https://dev.gnupg.org/T4474
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	315803
Attachments:	ebuild patch to apply: Use EXEEXT and -no-undefined even on Unix. patch for libgpg-error-1.29.ebuild: force -no-undefined libtool flag

Description Michael Haubenwallner (RETIRED) gentoo-dev

2016-05-27 13:40:52 UTC

Created attachment 435554 [details, diff]
ebuild patch to apply: Use EXEEXT and -no-undefined even on Unix.

Where "Unix" here in particular stands for "Cygwin".

Submitted upstream patch:
https://lists.gnupg.org/pipermail/gnupg-devel/2016-May/031119.html

Although this patch shouldn't change anything for "real" Unices, I'd suggest revbumping the ebuild.

Thanks!

Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev

2016-05-27 15:18:27 UTC

Cygwin is not Gentoo supported architecture, no reason to submit it here.
Anyway, we apply these kind of patches only after upstream accepts them.
And in most non critical cases also wait for upstream to release a new version.

Comment 2 Michael Haubenwallner (RETIRED) gentoo-dev

2016-11-16 15:23:28 UTC

Well, I'm about porting Gentoo Prefix to Cygwin (and vice versa).

But I'm fine with poking upstream here first, meanwhile keeping
https://gitweb.gentoo.org/repo/proj/prefix.git/commit/?id=ce4b4d168a2b091bec43d53f5d7075ebdcc3db3f

Comment 3 Michael Haubenwallner (RETIRED) gentoo-dev

2017-03-06 16:08:08 UTC

dropped from prefix overlay

Comment 4 Michael Haubenwallner (RETIRED) gentoo-dev

2017-03-06 17:22:34 UTC

Darn... Upstream applied Cygwin patch except for the -no-undefined libtool flag.

https://gitweb.gentoo.org/repo/proj/prefix.git/commit/?id=ec6685497e43fa513ca5b7ad81b852150d115cdf

Comment 5 Michał Górny archtester

2017-06-04 20:13:24 UTC

Ping. What's the status here?

Comment 6 Michael Haubenwallner (RETIRED) gentoo-dev

2017-06-06 08:07:39 UTC

Well, there's no upstream reaction on my explanation yet.
So the ebuild still requires:

@@ -33,6 +33,8 @@
 src_prepare() {
    default
    elibtoolize
+   # https://lists.gnupg.org/pipermail/gnupg-devel/2017-March/032671.html
+   sed -e '/@no_undefined\s*=\s*$/s/$/-no-undefined/' -i src/Makefile.in || die
 }

 multilib_src_configure() {


Alternative is something like: EXTRA_EMAKE="no_undefined=-no-undefined"

Comment 7 Michael Haubenwallner (RETIRED) gentoo-dev

2018-05-29 17:24:22 UTC

Created attachment 534032 [details, diff]
patch for libgpg-error-1.29.ebuild: force -no-undefined libtool flag

Comment 8 Michael Haubenwallner (RETIRED) gentoo-dev

2020-02-07 08:08:24 UTC

Patch is committed upstream now,
https://dev.gnupg.org/rE6e4b5ca624cb7f771c8dd1f12cbad851a5f0d782

Comment 9 Larry the Git Cow gentoo-dev

2021-01-06 10:21:41 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83bf9bb5b502afe4c094776cb06b3d2cd262aea1

commit 83bf9bb5b502afe4c094776cb06b3d2cd262aea1
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2021-01-06 10:21:23 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2021-01-06 10:21:29 +0000

    dev-libs/libgpg-error-1.41: drop undefined prefix hack, upstreamed
    
    Closes: https://bugs.gentoo.org/584330
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 dev-libs/libgpg-error/libgpg-error-1.41.ebuild | 9 ---------
 1 file changed, 9 deletions(-)