Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 584316

Summary: dev-util/pkgconfig: patch internal glib for Cygwin
Product: Gentoo Linux Reporter: Michael Haubenwallner (RETIRED) <haubi>
Component: [OLD] LibraryAssignee: Freedesktop bugs <freedesktop-bugs>
Status: RESOLVED WONTFIX    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 315803    
Attachments: patch internal glib for Cygwin

Description Michael Haubenwallner (RETIRED) gentoo-dev 2016-05-27 11:36:31 UTC
Created attachment 435546 [details, diff]
patch internal glib for Cygwin

While the Cygwin distro has both the pkgconfig and glib package, they do not use (and patch) pkgconfig's internal glib (which is patched by pkgconfig itself too).
So the Cygwin glib patches do not necessarily apply (and work) for pkgconfig's internal glib.

As a consequence, from https://github.com/cygwinports/glib2.0 I've forked
https://github.com/haubi/pkgconfig-glib-cygwin-patches, to ease transforming the glib Cygwin patches for use with pkgconfig's internal glib.
Comment 1 Pacho Ramos gentoo-dev 2016-05-28 11:19:47 UTC
Wouldn't be possible to try to report this to upstream to for not needing to carry this patch forever?

Thanks
Comment 2 Michael Haubenwallner (RETIRED) gentoo-dev 2016-11-16 11:15:52 UTC
Basically agreed, but doesn't feel that easy - situation is:
The Cygwin distro does not utilize pkg-config's internal glib.
The Cygwin distro maintains a number of glib patches in https://github.com/cygwinports/glib2.0, and I've yet to figure out why they still aren't upstreamed.
pkg-config does update their internal glib every once in a while, and I'd prefer not to bother them with Cygwin patches neither upstreamed yet nor needed by Cygwin itself - especially as long as Gentoo Cygwin Prefix is in this early state.

So for the time being I prefer to use Cygwin's glib patches for pkg-config's internal glib, and leave upstreaming to the Cygwin->glib road - even if I might probably find myself upstreaming Cygwin->glib anyway.

Meanwhile I can keep pkgconfig ebuilds in Prefix overlay if you prefer.
Comment 4 Fabian Groffen gentoo-dev 2021-01-06 10:24:50 UTC
We should really try and see if Cygwin can just use dev-util/pkgconf instead, which is just c89.