Summary: | __multijob_init: work around Cygwin FIFO shortcomings | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Michael Haubenwallner (RETIRED) <haubi> |
Component: | Core - Ebuild Support | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Other | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 315803, 611328 | ||
Attachments: | patch for __multijob_init to work with Cygwin FIFO |
Description
Michael Haubenwallner (RETIRED)
2016-05-24 11:02:54 UTC
Created attachment 435198 [details, diff]
patch for __multijob_init to work with Cygwin FIFO
This actually applies to multiprocessing.eclass as well. Any thoughts? (In reply to Michael Haubenwallner from comment #1) > Created attachment 435198 [details, diff] [details, diff] > patch for __multijob_init to work with Cygwin FIFO Can change mj_read_fd to readonly mode? I think we should do that, if it works correctly. Does it really matter which order mj_read_fd and mj_write_fd are opened? Why would it? (In reply to Michael Haubenwallner from comment #2) > This actually applies to multiprocessing.eclass as well. > > Any thoughts? Please submit a patch for multiprocessing.eclass to the gentoo-dev mailing list. (In reply to Zac Medico from comment #3) > Can change mj_read_fd to readonly mode? I think we should do that, if it > works correctly. Does it really matter which order mj_read_fd and > mj_write_fd are opened? Why would it? If mj_read_fd is opened in readonly mode, I see that pym/portage/tests/emerge/test_emerge_blocker_file_collision.py deadlocks in a call to prepstrip. (In reply to Zac Medico from comment #4) > (In reply to Zac Medico from comment #3) > > Can change mj_read_fd to readonly mode? I think we should do that, if it > > works correctly. Does it really matter which order mj_read_fd and > > mj_write_fd are opened? Why would it? > > If mj_read_fd is opened in readonly mode, I see that > pym/portage/tests/emerge/test_emerge_blocker_file_collision.py deadlocks in > a call to prepstrip. Also it deadlocks if mj_write_fd is opened first in writeonly mode. This is in the master branch: https://gitweb.gentoo.org/proj/portage.git/commit/?id=5a53e732efa0ee7e2a3f8afe90d729212ff187fb And in gentoo tree: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=077e60fb9c46247fc053df29b9416b46c90ae6c7 Thanks! |