Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 583336

Summary: sys-apps/portage etc-update --preen leaves behind tmp dir
Product: Portage Development Reporter: Dan Goodliffe <gentoo>
Component: UnclassifiedAssignee: Portage team <dev-portage>
Status: UNCONFIRMED ---    
Severity: minor    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Dan Goodliffe 2016-05-17 20:23:31 UTC
As per summary.
Line 845 of /usr/sbin/etc-update (in portage v2.3.0_rc1) just calls exit 0 if preen succeeds, bypassing the tidy up of tmp dir.
This leads to a build up of junk in /var/tmp

akira ~ # ls -d /var/tmp/etc-update-*
/var/tmp/etc-update-11490  /var/tmp/etc-update-15218
(and many more)

Reproducible: Always

Steps to Reproduce:
1. rm -r /var/tmp/etc-update-*
2. etc-update --preen
Scanning Configuration files...
3.ls -d /var/tmp/etc-update-*
/var/tmp/etc-update-14840




Suggest something like this at line 845 instead.

${PREEN} && die "Preen success" 0

Using die here seems a bit dirty, but that's where the current clean up is done.