Summary: | QA Violations in the tree via Github Pull Request 1327 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Göktürk Yüksek <gokturk> |
Component: | [OLD] Unspecified | Assignee: | Gentoo Quality Assurance Team <qa> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | mgorny |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/gentoo/gentoo/pull/1327 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Göktürk Yüksek
2016-05-03 05:47:00 UTC
I'm the person responsible for the orignal PR that got pulled here -> I'll have a look at the content that got in. There were multiple pushes in the PR and not all of them were ok. -- Antti Järvinen These points appear mostly intense nit pick. Either way they are reverted and no longer in place in the tree. (In reply to Ian Delaney from comment #2) > These points appear mostly intense nit pick. > Either way they are reverted and no longer in place in the tree. Maybe we should ask for some more reviews before things are pushed to the main repo (or a "reviewers" team)? There were some additional QA issues identified in the PR https://github.com/gentoo/gentoo/pull/1327 so I'll close the PR and open a new one that contains a cleaned version of the ebuild -> this ticket can be closed as my understanding is that commits listed by Götürk have already been reverted in the repository. All right Sirs, here https://github.com/gentoo/gentoo/pull/1406 is a 2nd try of the version bump for review, comments welcome. -- Antti Oh my, this one's old. |