Summary: | net-nntp/leafnode-1.11.11 : checkpeerlocal.c:(.text+0x1bd): undefined reference to `extract_v6mappedv4' | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Hans de Graaff <graaff> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gentoo, order+gentoo |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 625162 | ||
Bug Blocks: | |||
Attachments: |
emerge-history.txt
environment net-nntp:leafnode-1.11.11:20160414-092725.log ebuild for leafnode 2.0.0_alpha20140727 Patch for 'USE=-ipv6' build failure |
Description
Toralf Förster
2016-04-14 10:33:48 UTC
Created attachment 430428 [details]
emerge-history.txt
Created attachment 430430 [details]
environment
Created attachment 484346 [details]
ebuild for leafnode 2.0.0_alpha20140727
Latest alpha (2014), does compile despite the age.
Works for me.
#v+
|selu@barolo ~ $ leafnode-version
|version: leafnode-2.0.0.alpha20140727b
|current machine: Linux barolo 4.12.0-gentoo #1 SMP PREEMPT Sat Jul 8 10:19:55 CEST 2017 x86_64 Intel(R) Core(TM) i7-3517U CPU @ 1.90GHz GenuineIntel GNU/Linux
|bindir: /usr/bin
|sysconfdir: /etc/leafnode
|default spooldir: /var/spool/news
|default MTA: /usr/sbin/sendmail
|pcre version: 8.41 2017-07-05
#v-
Created attachment 484652 [details, diff]
Patch for 'USE=-ipv6' build failure
It'd suffice to always enable ipv6, i.e. scrap the USE-flag and configure with '--with-ipv6' (which is default).
Alternatively, there's one instance in checkpeerlocal.c that has been forgotten to
surround with '#ifdef HAVE_IPV6'. See attached patch.
(In reply to David Haller from comment #5) > Created attachment 484652 [details, diff] [details, diff] > Patch for 'USE=-ipv6' build failure Thanks for the patch. I have made myself, maintainer, added the patch, and unmasked the package. (In reply to Hans de Graaff from comment #6) > (In reply to David Haller from comment #5) > > Created attachment 484652 [details, diff] [details, diff] [details, diff] > > Patch for 'USE=-ipv6' build failure > > Thanks for the patch. I have made myself, maintainer, added the patch, and > unmasked the package. You're welcome. As I'm mostly just good at reading code and haven't dug through as thorough as usual. Have you looked at it and am I correct in assuming that the code in "if(IN6_IS..(&addr.sin6..)){ .. }" can only be reached anyway with IPv6 enabled? So, "boldly" ifdef'ing this out is correct? Maybe have it keyworded for a while longer... What about filing an upstream bug? Sebastian, I guess we can call 2.x at least "halfdead" upstream, as it's latest alpha is a year older than the 1.11.11 release from 2015-08-24 [1]. Considering NNTP is not in much demand today anyway, security patches are our first concern, and 1.11.x does seem to fullfill that. AW, right. Gitlab has storage issues just now. *sigh* (on twitter they say storage is back & validated, they're validating services now (11:0x UTC)) Anyway, I'd say, make 2.x slotted and masked (and unstable). Gentoo is about choice, right, including that to shoot yourself in the foot with e.g. a git or alpha version. So, Hans, I'd vote for accepting a (slotted, masked (like git stuff), unstable) 2.x ebuild if Sebastian submits one :) And then we wait for upstream to do stuff ... for both 1.x and 2.x :) [1] albeit, in the 2.x ChangeLog we find: 2013-07-10: [..] Forward-port from leafnode 1.11.11. [..] (In reply to David Haller from comment #7) > What about filing an upstream bug? As far as I can tell upstream is not active at all, but please feel free to file the bug upstream. (In reply to David Haller from comment #8) > Anyway, I'd say, make 2.x slotted and masked (and unstable). I have no intention of adding 2.x given the current upstream state. |