Bug 579770 – tgt should not be a dependency of cinder[iscsi]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description schmitt953 2016-04-12 19:43:43 UTC]

sy-cluster/cinder pulls in tgt as a dep of cinder if the iscsi use flag is enabled. Cinder supports both lio and tgt. Perhaps there should be a use flag for lio that makes tgt not a dep with the iscsi use flag and checks for the kernel modules required for lio. We can't require tgt because it has issues with 4k drives and lio works better for those drives. 4kn drives are the future, for now there will be a mix of 512e and 4kn.

[Comment 1 Matthew Thode ( prometheanfire ) 2016-04-14 01:23:47 UTC]

What client utils are used if lio is used over tgt?
Any other package or just a kernel module that needs to be verified? (how does cinder call lio)
Can they both be run at the same time?

This would work for the use flags.
REQUIRED_USE="iscsi? ( || ( tgt lio ) )"

[Comment 2 schmitt953 2016-04-18 03:40:35 UTC]

Hey Matt,
That's the exact syntax I used :). I also added an infiniband use flag for checking iser drivers in the kernel. I'm testing the new ebuild now. I'll post here when it builds.

[Comment 3 schmitt953 2016-04-18 05:01:40 UTC]

Created attachment 431034 [details]
fixed ebuild

[Comment 4 schmitt953 2016-04-18 14:19:30 UTC]

Created attachment 431128 [details]
cinder-2016.1.9999.ebuild

fixed the ewarn with modules

[Comment 5 schmitt953 2016-04-18 14:20:49 UTC]

One thing I noticed is the regular cinder init file doesn't install. Don't know if thatis intentional but I don't see anything starting the pid in /var/run. Nothing from files/cinder-init is called and placed into the directory.

[Comment 6 Matthew Thode ( prometheanfire ) 2016-04-20 21:31:24 UTC]

fixed the ebuild so it works and commited