Bug 579492

Summary:	perl-functions.eclass perl_fix_packlist retains reaped files in installed .packlists
Product:	Gentoo Linux	Reporter:	Kent Fredric (IRC: kent\n) (RETIRED) <kentnl>
Component:	Eclasses	Assignee:	Gentoo Perl team <perl>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	239510
Attachments:	perl-functions.eclass suggested patch

Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev

2016-04-10 08:28:12 UTC

Created attachment 430050 [details, diff]
perl-functions.eclass suggested patch

Due to upstream bug https://rt.cpan.org/Ticket/Display.html?id=113642,

generating a future packlist results in re-consuming an existing installed packlist.

This means when files get removed from future versions and thus removed from tree, the packlist entries for those files is silently retained.

This problem will periodically vanish every time you do a clean perl install by way of existing packlists falling out of the search path for new ones.

Attached is my suggested perl-functions.eclass patch, but it needs lots more eyes on.

It could have been done differently, ie:

 - record all invalid items in a file with echo >>
 - single pass .packlist -> .packlist.new

But a grep-per-case was the simplest thing that could work for now.

Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev

2016-04-10 13:21:50 UTC

This is even worse than I thought.

Because we're manually deleting the .3pm files after the install phase ... 

They're generated, ... and stored in the packlist.

But are subsequently not available past install time, despite reference in packlist.

This fix should resolve this slightly, but its also going to be reminder that
any user Portage-based features are going to potentially invalidate packlist in some way.

Comment 2 Andreas K. Hüttel archtester

2016-04-10 18:12:57 UTC

commit abee95677957faab99ba412b96b2da40fb23c133 (HEAD -> master, origin/master, origin/HEAD)
Author: Andreas K. Hüttel <dilfridge@gentoo.org>
Date:   Sun Apr 10 20:11:03 2016 +0200

    eclass: Improve packlist fixing, based on work by kent\n; bug 579492 and more

 eclass/perl-functions.eclass | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)