| Summary: | net-fs/samba-4.4.2[abi_x86_32] - Unknown dependency 'PROVISION' in 'samba-net.objlist' | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Dennis Schridde <dschridde+gentoobugs> |
| Component: | Current packages | Assignee: | Gentoo's SAMBA Team <samba> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=580956 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 489762 | ||
| Attachments: | build.log | ||
|
Description
Dennis Schridde
2016-03-30 10:19:11 UTC
I saw this as well. I disabled abi_x86_32 and I was able to build. It appears that 4.4.0_rc5-nopython-source4_libnet_wscript_build.patch is not entirely sufficient. I tried shifting the PROVISION dependency into the Python modules, but wasn't able to quickly create a patch that would not conflict with the abovementioned one. I will try again, when I have more time. P.S. The reason this happens is that PROVISION is defined in source4/param/wscript_build only if `not bld.env.disable_python`. This conditional is introduced by 4.2.7-nopython-source4_param_wscript_build.patch from https://dev.gentoo.org/~polynomial-c/samba-disable-python-patches-4.4.0_rc5.tar.xz. Seeing that both bld.SAMBA_SUBSYSTEM('PROVISION', ...) and bld.SAMBA_PYTHON('pyparam', ...) in source4/param/wscript_build have source=pyparam.c, I wonder whether that is correct or whether PROVISION should not actually depend on pyparam.c, but only on provision.c. Persists with 4.4.2 From looking at libnet/*, it seems that this is an integral part and it strictly depends on provision.h - i.e. there seems to be no obvious way to patch neither libnet nor its dependency on provision out of the code. Further, provision strictly depends on Python behind its non-Python API. Thus I created bug #580956 against dev-lang/python. (In reply to Dennis Schridde from comment #5) > Thus I created bug #580956 against dev-lang/python. The proper fix appears to be to remove `--disable-python` in the `!multilib_is_native_abi` code path of the ebuild and get rid of the nopython patchset. (In reply to Dennis Schridde from comment #6) > (In reply to Dennis Schridde from comment #5) > > Thus I created bug #580956 against dev-lang/python. > > The proper fix appears to be to remove `--disable-python` in the > `!multilib_is_native_abi` code path of the ebuild and get rid of the > nopython patchset. But that can't happen unless all of python gets 32-bit multilib support, which IMO is just nuts for what really amounts to one rather small use-case. (As in, it would likely be easier to fork this portion of samba to reimplement it so it doesn't need python) OK all -- is there anything that actually needs a 32bit libsamba-net-samba4.so ? Given I expect not (samba-4.2.x doesn't provide it and there hasn't been anything flagged against that package), how about we just cut building of this package for the alt abi? (In reply to Ian Stakenvicius from comment #8) > OK all -- is there anything that actually needs a 32bit > libsamba-net-samba4.so ? Given I expect not (samba-4.2.x doesn't provide it > and there hasn't been anything flagged against that package), how about we > just cut building of this package for the alt abi? yeah the previous version of this patch excluded the whole thing when python wasn't available. I don't know why the 4.4 patchset didn't match this but I'll restore said bebavhour ASAP. commit d239033ddf20ae175e3369fb0eceac1f39ae3f7e Author: Ian Stakenvicius <axs@gentoo.org> Date: Mon Apr 25 11:52:41 2016 -0400 net-fs/samba-4.4: drop building of libsamba-net-samba4.so from abi_x86_32 libsamba-net-samba4.so requires PROVISION as well as other dependencies that are libpython based, and so cannot be built for alternate ABIs. This section of the code was already disabled in the 4.2.x series but was erroneously re-enabled for 4.4. |
