Bug 577658

Summary:	[musl overlay?] x11-terms/rxvt-unicode-9.21-r99 with musl: error: 'LASTLOG_FILE' was not declared in this scope
Product:	Gentoo Linux	Reporter:	Nicholas Fish <gentoo>
Component:	Current packages	Assignee:	Gentoo musl team <musl>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	430702
Attachments:	Build log from failed rxvt-unicode-9.21-r99 build Disable utmp and wtmp on rxvt-unicode ebuild

Description Nicholas Fish 2016-03-17 21:15:17 UTC

Created attachment 428466 [details]
Build log from failed rxvt-unicode-9.21-r99 build

Please assign to musl@gentoo.org.

This bug should be made a blocker of: https://bugs.gentoo.org/show_bug.cgi?id=430702

Couple of errors attempting to build rxvt-unicode-9.21-r99 with musl:

In file included from ptytty_wrapper.C:9:0:
./../libptytty/src/logging.C: In function 'void update_lastlog(const char*, const char*)':
./../libptytty/src/logging.C:197:19: error: 'LASTLOG_FILE' was not declared in this scope
   if ((fd = open (LASTLOG_FILE, O_RDWR)) != -1)
                   ^
./../libptytty/src/logging.C: In member function 'void ptytty_unix::log_session(bool, const char*)':
./../libptytty/src/logging.C:348:17: error: 'WTMPX_FILE' was not declared in this scope
       updwtmpx (WTMPX_FILE, &utx);
                 ^
Makefile:60: recipe for target 'ptytty_wrapper.o' failed

Comment 1 Nicholas Fish 2016-03-17 21:16:58 UTC

Created attachment 428468 [details, diff]
Disable utmp and wtmp on rxvt-unicode ebuild

Comment 2 Anthony Basile gentoo-dev

2016-03-19 06:53:38 UTC

(In reply to Nicholas Fish from comment #1)
> Created attachment 428468 [details, diff] [details, diff]
> Disable utmp and wtmp on rxvt-unicode ebuild

I would have gone the path of doing and #ifdef LASTLOG_FILE and then define a reasonable default, but I'm okay with disabling this on the overlay.  Ideally we want patches that are upstreamable.