Summary: | app-emulation/wine-1.9.5 fails pre-merge checks with undefined reference to "main" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marco Napetti <marco.napetti> |
Component: | Current packages | Assignee: | Wine Maintainers <wine> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bob.mt.wya, uzytkownik2 |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
wine-1.9.5-premerge-fix.patch
pr69140-test-file.patch wine-1.9.5-pr69140-test-ebuild.patch |
Description
Marco Napetti
2016-03-13 14:14:25 UTC
Both my AMD and Intel systems have this same issue. Created attachment 428140 [details, diff]
wine-1.9.5-premerge-fix.patch
This ebuild patch fixes the problem with the premerge check.
That patch does not work because of the subsequent tests it does not correct... if ! ( "${T}"/69140 || false ) >/dev/null 2>&1; then First with the original code it should have been : "${T}"/pr69140 (the "pr" was missing) Now it should be : "${T}"/pr69140.o (added .o) Unfortunately a .o is not executable so the test always fails I think... so the test is useless... I saw the errors, but do not know how to correct them... Created attachment 428156 [details, diff]
pr69140-test-file.patch
Add some crap the pr69140 test to make it compile. Yeah C programs generally need a main() function somewhere :-)
Created attachment 428158 [details, diff]
wine-1.9.5-pr69140-test-ebuild.patch
Patch the stock Gentoo =app-emulation/wine-1.9.5 ebuild to test for a COMPILE TIME failure in the pr69140 MD4 test code... NOT a runtime failure!!
I've not tested these patches at all (disclaimer!!) ... But obviously the updated pr69140 test does "successfully fail" with my (unpatched) stock =sys-devel-gcc-5.3.0 build !!
I can't really be bothered to spend an hour rebuilding my gcc - but feel free to try the 2 patches out (*IF* you've already *PATCHED* your gcc 5.3.0 build) ...
Bedtime 8-/
*** Bug 577304 has been marked as a duplicate of this bug. *** *** Bug 577352 has been marked as a duplicate of this bug. *** Thanks Bob! MVP :) e08eca66f56c895a137a1a7e6cf554d50084c925 (In reply to NP-Hardass from comment #8) > Thanks Bob! MVP :) > > e08eca66f56c895a137a1a7e6cf554d50084c925 np :-/ (In reply to NP-Hardass from comment #8) > Thanks Bob! MVP :) > > e08eca66f56c895a137a1a7e6cf554d50084c925 Ahhh... But - now I've just checked... You've not added this test to older versions of Wine (<1.9.3) - but they are just as affected by this gcc bug! The Wine commit that caused the problem in the first place was: http://source.winehq.org/git/wine.git/blobdiff/71f018cba5191d99fbda8d3b9a25ccd6e422a8c9..dccb57dfd9c668eff5e672def93405be8a3303bd:/include/windef.h All that commit does is add the force_align_arg_pointer attribute to the stock Wine build flags. To replicate the issue (on amd64): attempt to build <app-emulation/wine versions-1.9.3: use stock / unpatched version of =sys-devel/gcc-5.3.0 with USE +custom-cflags CFLAGS+="-mstackrealign" (In reply to Bob Wya from comment #10) > (In reply to NP-Hardass from comment #8) > > Thanks Bob! MVP :) > > > > e08eca66f56c895a137a1a7e6cf554d50084c925 > > Ahhh... But - now I've just checked... You've not added this test to older > versions of Wine (<1.9.3) - but they are just as affected by this gcc bug! > > The Wine commit that caused the problem in the first place was: > http://source.winehq.org/git/wine.git/blobdiff/ > 71f018cba5191d99fbda8d3b9a25ccd6e422a8c9.. > dccb57dfd9c668eff5e672def93405be8a3303bd:/include/windef.h > > All that commit does is add the force_align_arg_pointer attribute to the > stock Wine build flags. > > To replicate the issue (on amd64): > attempt to build <app-emulation/wine versions-1.9.3: > use stock / unpatched version of =sys-devel/gcc-5.3.0 > with USE +custom-cflags > CFLAGS+="-mstackrealign" I'll apply across the board.
>
> I'll apply across the board.
OK thanks! ;-)
I have added the gcc patches linked in bug 574044 Comment 13 to /etc/portage/patches/sys-devel/gcc-5.3.0 and have rebuilt gcc. And now, with the current wine-1.9.5 ebuild, the merge goes through just fine. |