Bug 576514

Summary:	www-client/w3m upstream change
Product:	Gentoo Linux	Reporter:	Hadrien Lacour <hadrien.lacour>
Component:	Current packages	Assignee:	CJK Team <cjk>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	dlan, galtgendo, jstein
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Badly rendered html w3m-0.5.3-r9.ebuild

Description Hadrien Lacour 2016-03-05 13:43:08 UTC

Created attachment 427518 [details]
Badly rendered html

Using w3m in my mutt mailcap to render html, I stumbled upon a most annoying bug in that didn't happen on my Arch install: the attached html doesn't render accentuated characters properly.
So I tried to see what was the difference between the two distributions, and it looks like Arch (and Debian) uses a different, forked upstream that fixed a lot of bugs (including mine): https://github.com/tats/w3m

Seeing that the real upstream is pretty much dead, that some rather serious bugs are fixed in this fork (see https://raw.githubusercontent.com/tats/w3m/master/ChangeLog) and that the compilation process isn't that different, wouldn't an upstream change be beneficial for Gentoo too?

PS: I used 'elinks -dump -force-html -no-numbering -no-references' in mutt to temporarly fix the problem.

Comment 1 Hadrien Lacour 2016-03-13 22:25:11 UTC

It looks like https://github.com/tats/w3m is actually a mirror for https://anonscm.debian.org/cgit/collab-maint/w3m.git/

Comment 2 Naohiro Aota gentoo-dev

2016-03-16 07:29:49 UTC

Actually, I'm collaborating with the Debian maintainer, and already pulling necessary patch from there (e.g. files/w3m-0.5.3-url-schema.patch). Please specify the problem so that I'll find patch and add it to Gentoo tree.

Comment 3 Naohiro Aota gentoo-dev

2016-03-16 07:36:43 UTC

> the attached html doesn't render accentuated characters properly.

And this seems to happen by a configuration knob: "Use ASCII equivalents to display entities  (*)YES  ( )NO"

Comment 4 Hadrien Lacour 2016-03-16 18:06:58 UTC

You're right, sorry for the false alarm. Still, I don't understand why the defaults are not the same for the fork and why we should works with a lot of patches instead of using a clean fork.

Comment 5 Yixun Lan archtester

2016-11-29 08:19:29 UTC

Created attachment 454656 [details]
w3m-0.5.3-r9.ebuild

@naota

what do you think if we directly tracking the github repository?

attach ebuild is a prototype of this idea, also could you help to check which patches we have to forward port to the new version? as I haven't looked at them, nor am I familiar with ..

Comment 6 Yixun Lan archtester

2016-12-03 05:50:15 UTC

commit 8980adf0be95c6fa394f71a2b7ff63b475c87aa5
Author: Yixun Lan <dlan@gentoo.org>
Date:   Sat Dec 3 13:47:12 2016 +0800

    www-client/w3m: version bump, fix various security issue

    1) tracking new repo source from github
       https://github.com/tats/w3m
    2) fix various security issue, see bug 600176
    3) drop USE=vanilla, since all patches accepted by upstream

    Gentoo-Bug: 576514, 600176

    Package-Manager: portage-2.3.2
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8980adf0be95c6fa394f71a2b7ff63b475c87aa5