| Summary: | dev-libs/wayland-1.10.0-r1 fails tests due to a too long socket path | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | tka <tka> |
| Component: | [OLD] Library | Assignee: | Gentoo X packagers <x11> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | paolo.pedroni |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
build.log
test-suite.log |
||
|
Description
tka
2016-03-03 08:46:06 UTC
Created attachment 427282 [details]
test-suite.log
socket path length has a limit of 108 bytes imposed by the structure they are defined (man unix). So they can't be created in such a long path. So we'll need to see if we can safely create them in $TMP or something instead of whatever env path (maybe one of $XDG_*) it is using, or pointing that variable to higher up in /tmp or something. And at worst we could disable these subtests I suppose. Another option could be to shorten those suffix numbers somehow to fit in the 108 limit most of the time in the common /var/tmp/ case. As it happens, it being a revision bump, adding the "-r1" to the path is what triggered this compared to 1.10.0 :S It happens in dev-libs/wayland-1.9.0 as well: make check-TESTS make[3]: Entering directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' make[4]: Entering directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' PASS: client-test PASS: fixed-test PASS: array-test PASS: list-test PASS: map-test PASS: headers-test PASS: queue-test PASS: event-loop-test PASS: message-test PASS: resources-test PASS: signal-test FAIL: display-test PASS: connection-test PASS: socket-test PASS: os-wrappers-test FAIL: sanity-test make[5]: Entering directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' make all-recursive make[6]: Entering directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' make[7]: Entering directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' make[7]: Leaving directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' make[6]: Leaving directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' make[5]: Leaving directory '/var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0-abi_x86_32.x86' ============================================================================ Testsuite summary for wayland 1.9.0 ============================================================================ # TOTAL: 16 # PASS: 14 # SKIP: 0 # XFAIL: 0 # FAIL: 2 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to https://bugs.freedesktop.org/enter_bug.cgi?product=Wayland&component=wayland&version=1.9.0 ============================================================================ Makefile:1873: recipe for target 'test-suite.log' failed test-suite.log excerpt: FAIL: display-test ================== unable to open lockfile /var/tmp/portage/dev-libs/wayland-1.9.0/temp/runtime-dir/wayland-tests/wayland-test-16016-1466599078889477.lock check permissions display-test: /var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0/tests/test-compositor.c:313: display_create: Assertion `stat == 0 && "Failed adding socket"' failed. test "threading_read_after_error_tst": signal 6, fail. ---------------------------------------- unable to open lockfile /var/tmp/portage/dev-libs/wayland-1.9.0/temp/runtime-dir/wayland-tests/wayland-test-16046-1466599078895543.lock check permissions display-test: /var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0/tests/test-compositor.c:313: display_create: Assertion `stat == 0 && "Failed adding socket"' failed. test "threading_read_eagain_tst": signal 6, fail. [....] FAIL: sanity-test ================= unable to open lockfile /var/tmp/portage/dev-libs/wayland-1.9.0/temp/runtime-dir/wayland-tests/wayland-test-16043-1466599078892573.lock check p ermissions sanity-test: /var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0/tests/test-compositor.c:313: display_create: Assertion `stat == 0 && "F ailed adding socket"' failed. test "tc_timeout3_tst": signal 6, fail. ---------------------------------------- unable to open lockfile /var/tmp/portage/dev-libs/wayland-1.9.0/temp/runtime-dir/wayland-tests/wayland-test-16052-1466599078894503.lock check p ermissions sanity-test: /var/tmp/portage/dev-libs/wayland-1.9.0/work/wayland-1.9.0/tests/test-compositor.c:313: display_create: Assertion `stat == 0 && "F ailed adding socket"' failed. test "tc_timeout2_tst": signal 6, pass. ---------------------------------------- Timeout was set to 1 second from now. Test timed out. Client 'timeout_tst' was killed by signal 6 (In reply to Paolo Pedroni from comment #3) > It happens in dev-libs/wayland-1.9.0 as well: Please disregard my comment, it's a different issue altogether. Sorry for the bugspam... I've shortened the TMPDIR subdir name used from "runtime-dir" to "xdr" and with 1.13.0 they at least fit now with /var/tmp as well. But I'm afraid they'll not fit if we happen to have a 1.13.0-r1 or similar. I'm not sure what to do further to avoid that; maybe making the subdir one char or removing the subdir altogether and let it create its wayland-tests-123456 subdir directcly in $T if the dir permissions are fine, or try to use /tmp. But maybe it's fine for now with the subdir reduction and we hope -r1's are never needed... :) commit bd72168fbd11f8bd055b92a75aa9e73f14eb5b7a Author: Mart Raudsepp <leio@gentoo.org> Date: Mon Apr 10 02:27:41 2017 +0300 dev-libs/wayland-9999: Port to EAPI-6 Also try to address socket path 108 byte limit restriction caused test failures by cutting down the XDG_RUNTIME_DIR subdir length. Wayland tests used to create a wayland-tests/ subdir under it, but since before 1.13.0 it creates a wayland-tests-RANDOM/ subdir (RANDOM is 6 random characters), which makes tests fail on socket path length even with PORTAGE_TMPDIR=/tmp, let alone /var/tmp. I think shortening the subdir from "runtime-dir" to "xdr" makes it fit in both cases, unless we are dealing with a 1.xx.y-r1 revision, in which case /var/tmp might fail. commit 73068fd11c4219214b4eb0989948fa4c8b9f651f Author: Mart Raudsepp <leio@gentoo.org> Date: Mon Apr 10 04:00:39 2017 +0300 dev-libs/wayland: bump to 1.13.0 Gentoo-bug: 611062 |
