| Summary: | git-2.eclass: drop -u | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michal Privoznik <miso.privoznik> |
| Component: | Eclasses | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | balthazar.ad, fatzer2, gentoo, luke-jr+gentoobugs, stanislav |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
eclass-debug.log
emerge --info patch |
||
Created attachment 427138 [details]
emerge --info
Created attachment 427140 [details, diff]
patch
This looks to not affect to -r3 eclass... this one is tagged as deprecated, but maybe maintainers want to solve it anyway :/ (In reply to Pacho Ramos from comment #3) > This looks to not affect to -r3 eclass... this one is tagged as deprecated, > but maybe maintainers want to solve it anyway :/ Well, there are still ~700 packages inheriting git-2, so maybe it's worth fixing, esp. if the fix is that simple. Note that the '-u' flag was removed only from the git-pull, git-fetch still has it. So I'm not sure if your patch is correct because -u may be essential here somewhy or just a type and something other should be on it's place. After-all this one may be even a git bug, but IMHO no mere than a bit obscure documentation mentioning it on the git-pull man page. Also note that it affects only git 2.6+, but due to recent security alarms and stabilization of 2.7.3. it will affect more people. I agree that fixing this one is essential due to lots of ebuilds still inherit the eclass, even in the main tree, not speaking about overlays. *** Bug 578672 has been marked as a duplicate of this bug. *** *** Bug 577874 has been marked as a duplicate of this bug. *** Any ETA conerning this fix? I'm forced to use git-2 to avoid downloading useless submodules, but even this isn't possible. Use git-r3.eclass instead (In reply to Pacho Ramos from comment #9) > Use git-r3.eclass instead Does this mean that gentoo developers will happily merge patch that reworks all the git-2 to git-r3 eclass? Because if not, I'm afraid we are leaving plenty of broken ebuilds behind: lisa ~ # grep -r "inherit.*git-2" /usr/portage/ | wc -l 642 lisa ~ # cat /usr/portage/metadata/timestamp Sat Aug 6 07:39:47 UTC 2016 The will and they will welcome that work to be done for migrating from the deprecated eclasses (like python.eclass too and many others ;) |
Created attachment 427136 [details] eclass-debug.log So I've tried to rebuild net-im/psi-9999. But as it turns out, my local clone of repo was unable to update: + printf '%s\n' 'git pull -f -u ' + chgrp portage /var/tmp/portage/net-im/psi-9999/temp/eclass-debug.log + chmod g+w /var/tmp/portage/net-im/psi-9999/temp/eclass-debug.log + git pull -f -u error: unknown switch `u' As I've investigated, emerge is trying to run 'git pull -f -u' from within the repo, but the git pull manpage states quite clearly: -u, --update-head-ok By default git fetch refuses to update the head which corresponds to the current branch. This flag disables the check. This is purely for the internal use for git pull to communicate with git fetch, and unless you are implementing your own Porcelain you are not supposed to use it. In fact, trying to run 'git pull -u' in any other git repo I have results in the very same error.