| Summary: | games-emulation/dolphin-9999: Revision shouldn't be overridden | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Tear♪ <marach5> |
| Component: | [OLD] Games | Assignee: | Devan Franchini (RETIRED) <twitch153> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | marach5 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Sounds like a reasonable thing to remove. I'll be removing that then. Done and done, I'll keep this open until tomorrow to ensure it goes through. |
Line 142 of dolphin-9999.ebuild contains: "-DDOLPHIN_WC_REVISION=${PV}" I believe this line should be removed, as it removes git version information from the title bar and "About" popup and replaces it with 9999. It's quite important to know what revision you're running when submitting issues or game tests upstream. Additionally, the netplay function intentionally refuses to connect clients with different revisions to ensure compatibility and stability, so this line makes it impossible for a Gentoo user to connect to anyone other than another Gentoo user, and might result in instability if their revisions differ. With this line removed, the version string becomes dolphin-4.0-9050-dirty (as of the time of writing). The "-dirty" suffix does not break compatibility with users of official packages.