Bug 57605 – nikibot-0.8.ebuild (New Package)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jan-David Quesel 2004-07-19 09:13:57 UTC]

Hi,

this is an ebuild for nikibot. its a lightwight irc bot with a lua script interface. Maybe someone else could also need it. I haven't written much document yet but...
Would be nice if it could be inserted into the portage. I would suggest to place it at net-irc/nikibot.

regards,
jan

[Comment 1 Jan-David Quesel 2004-07-19 09:15:33 UTC]

Created attachment 35750 [details]
nikibot-0.8.ebuild

[Comment 2 Sven Wegener 2004-07-21 17:45:25 UTC]

Some comments to your ebuild:

- nikibot-${PV} is equivalent to ${P} if package is named nikibot
- Initial KEYWORDS should be marked ~
- The dependency should be >=dev-lang/lua-5 otherwise we'll lock users
  to dev-lang/lua-5.0
- The ./configure part should be replaced with econf. And if src_compile only
  contains econf and emake without arguments, src_compile can be left out.
- src_install can be made with "make DESTDIR=${D} install", which is preferred
  over setting the prefix.
- On my system I need nikibot linked against libdl because of unresolved
  symbols in liblua.

As you're the maintainer of nikibot, some comments to your package. You're forcing debug mode. The user has no possibilty of turning it off, besides
editing the include file. You should probably move it into the configure
script and make it default to off. As mentioned above, on my system I need
nikibot linked against libdl because of unresolved symbols in liblua.
"pkg-config --libs lua" says "-llua -llualib -ldl -lm" are needed. And you're
adding the libs to CXXFLAGS, CXXFLAGS is normally only used for compiling.
The libs should be added to nikibot_LDADD or LIBS.

[Comment 3 Jan-David Quesel 2004-07-22 03:45:31 UTC]

Thanks for the feedback.
I have turned off debug mode. Its nice that you have found out which libs are missing, when compiling against >lua-5.0. I added them to the Makefile.in and Makefile.am also i moved the libincludes to nikibot_LDADD.
Also i changed the ebuild based on what you mentioned about it.

[Comment 4 Jan-David Quesel 2004-07-22 03:47:45 UTC]

Created attachment 35937 [details]
nikibot 0.8 ebuild... changed after comments...

[Comment 5 Sven Wegener 2004-07-23 16:09:37 UTC]

Commited to CVS. Some small changes:
- I changed SRC_URI to the sourceforge site
- Added RESTRICT="nomirror" as sourceforge has a good mirror network
- Added IUSE=""
- I had to touch src/Makefile.in in src_unpack because it's newer than
  src/Makefile.am and we want to avoid running automake at compile time