Bug 575102

Summary:	sys-apps/net-tools[nls]: should link w/-lintl
Product:	Gentoo Linux	Reporter:	Eric N. Vander Weele <ericvw>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	floppym, jstein
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	574794
Attachments:	Patch for sys-apps/net-tools ebuild to support '-lintl' when USE='nls'

Description Eric N. Vander Weele 2016-02-18 21:19:12 UTC

`USE='nls' emerge sys-apps/net-tools` does not add '-lintl' to when linking.

I considered patching just the ebuild to manipulate LIBS, but the net-tools Makefile does not support the LIBS environment variable.

This is blocking bug 574794.

Patch to follow.

Comment 1 Eric N. Vander Weele 2016-02-18 21:23:25 UTC

Created attachment 425864 [details, diff]
Patch for sys-apps/net-tools ebuild to support '-lintl' when USE='nls'

Comment 2 Mike Gilbert gentoo-dev

2016-02-18 21:31:47 UTC

Comment on attachment 425864 [details, diff]
Patch for sys-apps/net-tools ebuild to support '-lintl' when USE='nls'

You're putting $(LIBS) in the wrong place; it should go after any object files on the command line.

Also, I don't think libintl is used on glibc systems; I have never run into a build failure on my vanilla Gentoo system.

Comment 3 Eric N. Vander Weele 2016-02-18 22:04:35 UTC

> You're putting $(LIBS) in the wrong place; it should go after any object
> files on the command line.

Thanks for catching that.  I will update appropriately.

> Also, I don't think libintl is used on glibc systems; I have never run into
> a build failure on my vanilla Gentoo system.

Is there a mechanism to determine whether glibc is provided or not to make the patching conditional?  I'm still getting familiar with gentoo myself and ebuilds and would like to learn the proper way to do this (and to contribute).

Comment 4 SpanKY gentoo-dev

2016-02-18 23:31:00 UTC

you should just send patches upstream and i'll review/merge them there