Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 574782

Summary: roverlay: "add-policy default" not applied when not configured explicitly
Product: Portage Development Reporter: Benda Xu <heroxbd>
Component: Third-Party ToolsAssignee: André Erdmann <dywi>
Status: RESOLVED FIXED    
Severity: critical Keywords: InVCS
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Benda Xu gentoo-dev 2016-02-15 13:28:57 UTC
When there is a revbump, an assertion fails as:

Traceback (most recent call last):
   .... ....
  File "/usr/lib64/python3.4/site-packages/roverlay/overlay/pkgdir/packagedir_base.py", line 394, in package_try_replace
    assert package_info.overlay_addition_override is addition_override
AssertionError

Where package_info.overlay_addition_override is "None" and addition_override is 0.

package_info.overlay_addition_override is supposed to be set to 0 in PackageAdditionControlDefaultAction.  But that action is not added in the shipped package_rules:

MATCH:
   or
      * repo_name ,= r-forge
      * repo_name ,= rstan
ACTION:
   pass
ELSE:
   rename category s/^(?P<repo>[^-/]+)([-/].*)?$/sci-\g<repo>/
END;

It is needed write "add-policy default" explicitly to circumvent this bug:

MATCH:
   or
      * repo_name ,= r-forge
      * repo_name ,= rstan
ACTION:
   add-policy default  
ELSE:
   add-policy default
   rename category s/^(?P<repo>[^-/]+)([-/].*)?$/sci-\g<repo>/
END;

I guess this is not an intended behavior.

Reproducible: Always
Comment 2 Benda Xu gentoo-dev 2016-02-19 05:31:14 UTC
Thanks André. I pulled the newest version to the roverlay vm.