Bug 574398

Summary:	media-gfx/xv-3.10a-r18 doesn't grok common file formats
Product:	Gentoo Linux	Reporter:	Norman Yarvin <norman.yarvin>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	achurch+gentoo, ulm
Priority:	Normal
Version:	10.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fixed ebuild for xv Corrected fix

Description Norman Yarvin 2016-02-11 06:37:52 UTC

Created attachment 425182 [details]
Fixed ebuild for xv

Since updating to -r18, xv won't open jpg or png files, at least not as images.  The problem is that the -r18 ebuild uses "append-cppflags" to enable jpg and png where it should use "append-cflags".  (This is a C program, not a C++ one!)  Fixed ebuild attached.

Comment 1 Andrew Church 2016-02-12 15:15:59 UTC

Created attachment 425330 [details, diff]
Corrected fix

CPPFLAGS normally means "preprocessor flags" (CXXFLAGS is for the C++ compiler) so I think append-cppflags is correct.  The problem is that the make command line doesn't include ${CPPFLAGS}, only ${CFLAGS}.  Patch attached to make that addition.

Comment 2 Ulrich Müller gentoo-dev

2016-02-14 12:20:38 UTC

(In reply to Andrew Church from comment #1)
> Created attachment 425330 [details, diff] [details, diff]
> Corrected fix

Thanks, fixed in -r19.