Summary: | sys-apps/portage: compiler QA checks should use `grep -a` on log files | ||
---|---|---|---|
Product: | Portage Development | Reporter: | William Throwe <wtt6> |
Component: | Core - Interface (emerge) | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | itumaykin+gentoo, sbraz |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 573774 | ||
Attachments: |
games-roguelike/nethack build.log.gz
build.log.gz with --debug |
Description
William Throwe
2016-02-10 02:44:51 UTC
we're already running grep through LC_CTYPE=C which means it shouldn't trigger the binary warning due to encoding issues, and that log file has no embedded NULs. so it shouldn't be triggering that state. does this happen every time ? if so, re-run emerge with the --debug flag and attach that full log here please. Created attachment 425608 [details]
build.log.gz with --debug
This does happen consistently. --debug build log attached. Experimenting with running zgrep on the log file, I get the expected output with my standard LC_CTYPE=en_US.UTF-8 but "Binary file (standard input) matches" with LC_CTYPE=C (as is done by portage).
Here are my locale settings, in case that's useful:
LANG=POSIX
LC_CTYPE=en_US.UTF-8
LC_NUMERIC="POSIX"
LC_TIME=en_DK.UTF-8
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=
I experiment the same behaviour. I can confirm that changing LC_CTYPE to something like en_US.UTF-8 in /usr/lib64/portage/python3.5/install-qa-check.d/90gcc-warnings fixes the issue. I'm afraid --debug will not add anything relevant as debugging is disabled by the QA script: https://github.com/gentoo/portage/blob/master/bin/install-qa-check.d/90gcc-warnings#L8 LC_CTYPE=C grep 'implicit declaration' /var/tmp/portage/net-irc/eggdrop-1.6.21-r1/temp/build.log Binary file /var/tmp/portage/net-irc/eggdrop-1.6.21-r1/temp/build.log matches # LC_CTYPE=en_US.UTF-8 grep 'implicit declaration' /var/tmp/portage/net-irc/eggdrop-1.6.21-r1/temp/build.log .././mc_greet.mod/mc_data.c:129:2: warning: implicit declaration of function ‘chmod’ [-Wimplicit-function-declaration] * .././mc_greet.mod/mc_data.c:129:2: warning: implicit declaration of function ‘chmod’ [-Wimplicit-function-declaration] # file /var/tmp/portage/net-irc/eggdrop-1.6.21-r1/temp/build.log /var/tmp/portage/net-irc/eggdrop-1.6.21-r1/temp/build.log: UTF-8 Unicode text, with very long lines, with CRLF, CR, LF line terminators, with escape sequences yet more LC_ issues Fixed in https://github.com/gentoo/portage/commit/91e1dd94c1615bf97d5bc42dac4d64876919e768, which is included in 2.3.0_rc1. |