Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 574046

Summary: net-libs/libproxy-0.4.13 released
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component: [OLD] LibraryAssignee: Freedesktop bugs <freedesktop-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: phantom4
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 549734    

Description Arfrever Frehtes Taifersar Arahesis 2016-02-06 22:07:47 UTC 
net-libs/libproxy-0.4.12 was released on 2016-01-12.
https://github.com/libproxy/libproxy/releases

From NEWS file:

"New in version 0.4.12
==============================
* Move development to github.com/libproxy/libproxy
* Fix fd leak in get_pac (Bug #185)
* Detect running MATE session (Bug #186, Part1).
* Fix linking of perl bindings to pthread (Bug #182)
* Correctly detect spidermonky (mozjs185) (Bug #188)
* Stop pxgsettings from segfaulting on exit (Bug #192)
* Fix test #10 (Bug #189)
* Fix build on Mac OS X (Bug #183)
* Add a generic KDE Config module (fix crashes of Qt5 based
  apps) (issue#4)"


-HOMEPAGE="https://code.google.com/p/libproxy/"
+HOMEPAGE="https://github.com/libproxy/libproxy"


Support for KDE 5 was added in this version:
https://github.com/libproxy/libproxy/commit/bd9bf72e15107e6c6133b438c700dd42d79c9d60
Qt / KDE libraries are no longer used, and kreadconfig5 / kreadconfig executables are called instead:

+        try {
+            // Try the KF5 one first
+            command = "kreadconfig5";
+            kde_config_val("proxyType", "-1");
+            return; // Worked
+        }
+        catch(...) {}
+
+        try {
+            // The KDE4 one next
+            command = "kreadconfig";
+            kde_config_val("proxyType", "-1");
+            return; // Worked
+        }
+        catch(...) {}

$ qfile -Sv /usr/bin/kreadconfig*
kde-apps/kreadconfig-15.08.3:4/15.08 (/usr/bin/kreadconfig)
kde-frameworks/kconfig-5.18.0:5/5.18 (/usr/bin/kreadconfig5)

So net-libs/libproxy-0.4.12 ebuild probably should have this dependency:
RDEPEND="${RDEPEND}
    kde? ( || (
        kde-frameworks/kconfig:5
        kde-apps/kreadconfig:4
    ) )"
This dependency is not needed in DEPEND, adding it only to RDEPEND will suffice.

dev-util/automoc should be dropped from DEPEND.

Backporting of https://github.com/libproxy/libproxy/commit/8ca0db36983e9154c808288fea4cbdfc9a7ea4c5 is needed to allow usage of -DWITH_KDE option, which replaces -DWITH_KDE4 option.


In metadata.xml:
-<remote-id type="google-code">libproxy</remote-id>
+<remote-id type="github">libproxy/libproxy</remote-id>
Comment 1 Arfrever Frehtes Taifersar Arahesis 2016-02-06 22:16:27 UTC 
And usage of -DWITH_KDE option will not need to be dependent on multilib_is_native_abi:

-    $(multilib_is_native_abi && cmake-utils_use_with kde KDE4 \
-        || echo -DWITH_KDE4=OFF)
+    $(cmake-utils_use_with kde KDE)
Comment 2 . 2016-04-05 19:26:46 UTC 
Pull request: https://github.com/gentoo/gentoo/pull/1202
Comment 3 . 2016-04-05 21:56:03 UTC 
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #0)
> dev-util/automoc should be dropped from DEPEND.
Why?
Comment 4 Arfrever Frehtes Taifersar Arahesis 2016-04-06 11:36:12 UTC 
(In reply to Jan Chren (rindeal) from comment #3)
> (In reply to Arfrever Frehtes Taifersar Arahesis from comment #0)
> > dev-util/automoc should be dropped from DEPEND.
> Why?

dev-util/automoc is needed by find_package(Automoc4 ${_REQ_STRING_KDE4}) in /usr/share/apps/cmake/modules/FindKDE4Internal.cmake needed by find_package(KDE4Internal ${_req} ${_quiet} NO_POLICY_SCOPE) in /usr/share/cmake/Modules/FindKDE4.cmake PREVIOUSLY needed by find_package(KDE4) in libproxy/cmake/modules/config_kde4.cmk of libproxy.
libproxy/cmake/modules/config_kde4.cmk was deleted in https://github.com/libproxy/libproxy/commit/bd9bf72e15107e6c6133b438c700dd42d79c9d60.
Comment 5 . 2016-04-10 11:35:40 UTC 
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #4)
> dev-util/automoc is needed by find_package(Automoc4 ${_REQ_STRING_KDE4}) in
> /usr/share/apps/cmake/modules/FindKDE4Internal.cmake needed by
> find_package(KDE4Internal ${_req} ${_quiet} NO_POLICY_SCOPE) in
> /usr/share/cmake/Modules/FindKDE4.cmake PREVIOUSLY needed by
> find_package(KDE4) in libproxy/cmake/modules/config_kde4.cmk of libproxy.
> libproxy/cmake/modules/config_kde4.cmk was deleted in
> https://github.com/libproxy/libproxy/commit/
> bd9bf72e15107e6c6133b438c700dd42d79c9d60.

Impressive, thanks for explanation.
Comment 6 Pacho Ramos gentoo-dev 2016-04-17 11:31:28 UTC 
There are a few issues that should be considered before: 
- bug 549734 needs to be finally handled if possible 
- Looking to Fedora package, it seems that we will need to apply some of their patches to prevent some regressions: http://pkgs.fedoraproject.org/cgit/rpms/libproxy.git/tree/
Comment 7 . 2016-04-17 18:46:22 UTC 
Further considering https://github.com/libproxy/libproxy/issues/16#issuecomment-200372535 and https://github.com/libproxy/libproxy/issues/23, I think that we should just wait until 0.4.13 is out, which should be out soon and shouldn't require that amount of patches.
Comment 10 Arfrever Frehtes Taifersar Arahesis 2016-05-08 08:26:10 UTC 
Choices in || ( ... ) should be ordered from best to worst (when applicable), so I suggest to prefer net-libs/webkit-gtk:4= before net-libs/webkit-gtk:3= and kde-frameworks/kconfig:5 before kde-apps/kreadconfig:4.


There is WITH_WEBKIT3 option in build system, but seemingly no WITH_WEBKIT option:

$ grep -Ei 'option.*webkit' CMakeLists.txt **/*.@(cmake|cmk)
CMakeLists.txt:option(WITH_WEBKIT3 "Build against gtk-3 version of webkitgtk" OFF)
$

So "-DWITH_WEBKIT=$(multilib_is_native_abi && usex webkit || echo 'OFF')" line in ebuild probably should be deleted.
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-05-08 08:41:00 UTC 
:= operator within || () is invalid.
Comment 12 Arfrever Frehtes Taifersar Arahesis 2016-05-08 08:48:45 UTC 
Is support for net-libs/webkit-gtk:3 in net-libs/libproxy needed at all? Maybe it could be dropped.
Comment 13 Pacho Ramos gentoo-dev 2016-05-08 09:26:03 UTC 
[master bd2a59b] net-libs/libproxy: Fix gmcs detection (#549734) and webkit dependencies (#574046#c10)
 1 file changed, 15 insertions(+), 16 deletions(-)
 rename net-libs/libproxy/{libproxy-0.4.13.ebuild => libproxy-0.4.13-r1.ebuild} (87%)