Bug 572796

Summary:	media-plugins/audacious-plugins-3.7.1: now media-libs/adplug DEP for gtk3/qt5 support?
Product:	Gentoo Linux	Reporter:	Bruno <bonbons>
Component:	Current packages	Assignee:	Tony Vroon (RETIRED) <chainsaw>
Status:	RESOLVED FIXED
Severity:	normal	CC:	onigino, sound
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Bruno 2016-01-24 18:56:54 UTC

From 3.6.2-r1 to 3.7.1 a RDEPEND for media-libs/adplug has been added for the USE=gtk3 and USE=qt5 cases.

Is that change in dependency correct or a bug introduced while bumping?
If it's not a bug a comment in the ebuild explaining why gtk3/qt5 support need adplug would be helpful.

There is already the USE=adplug flag to control adplug decoder support.

Comment 1 Enne Eziarc 2017-10-11 20:26:34 UTC

FWIW, the ebuild is at fault here. Audacious 3.7, 3.8 and 3.9 all build and run fine if the erroneous dependency is removed from it. USE=adplug isn't even passed through to the build system, causing an automagic dependency (another bug).

Comment 2 David Seifert gentoo-dev

2017-11-05 11:31:58 UTC

*** Bug 590418 has been marked as a duplicate of this bug. ***

Comment 3 Larry the Git Cow gentoo-dev

2017-11-05 11:49:32 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=beae50663486be82a96836334c9e45d1b4416d40

commit beae50663486be82a96836334c9e45d1b4416d40
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2017-11-05 11:49:02 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2017-11-05 11:49:02 +0000

    media-plugins/audacious-plugins: Version bump to 3.9
    
    Closes: https://bugs.gentoo.org/564466
    Closes: https://bugs.gentoo.org/572334
    Closes: https://bugs.gentoo.org/572796
    Closes: https://bugs.gentoo.org/573886
    Closes: https://bugs.gentoo.org/573888
    Closes: https://bugs.gentoo.org/590008
    Closes: https://bugs.gentoo.org/611106
    Closes: https://bugs.gentoo.org/636318
    Closes: https://bugs.gentoo.org/636320
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 media-plugins/audacious-plugins/Manifest           |   1 +
 .../audacious-plugins/audacious-plugins-3.9.ebuild | 164 +++++++++++++++++++++
 .../audacious-plugins-9999.ebuild                  | 164 +++++++++++++++++++++
 media-plugins/audacious-plugins/metadata.xml       |  46 +++---
 4 files changed, 353 insertions(+), 22 deletions(-)