Summary: | dev-lisp/sbcl-1.1.18 : sandbox issue | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Panagiotis Christopoulos (RETIRED) <pchrist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugs, dearazzy, nvinson234, proxy-maint, qa, vamp898 |
Priority: | Normal | Keywords: | QAcanfix |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 573544 | ||
Attachments: |
dev-lisp:sbcl-1.1.18:20160120-204314.log.bz2
emerge-history.txt sandbox-27984.log |
Description
Toralf Förster
2016-01-20 20:55:26 UTC
Created attachment 423452 [details]
dev-lisp:sbcl-1.1.18:20160120-204314.log.bz2
Created attachment 423454 [details]
emerge-history.txt
Created attachment 423456 [details]
sandbox-27984.log
*** Bug 573082 has been marked as a duplicate of this bug. *** I thought pchrist had left gentoo months ago. Do you still wish to continue maintaining this? [QA] I have reverted commit https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=944c46edbf96fffc7d9151853ba361589d6a13d0 because it had several issues: - This is a build-time issue, so it should have been fixed in sbcl-1.1.18.ebuild without a revision bump to -r1. - What is $(PORTAGE_BUILDDIR) supposed to do? These should be curly {} braces. - PORTAGE_BUILDDIR is not defined by PMS but an internal variable of Portage, so ebuilds must not use it. - Missing "|| die" after the sed command. New fix committed here: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd295fdf21d6afba9018e518f92e6e8c94e1c457 Please test. (In reply to Ulrich Müller from comment #6) > [QA] I have reverted commit > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=944c46edbf96fffc7d9151853ba361589d6a13d0 because it had several issues: > > - This is a build-time issue, so it should have been fixed in > sbcl-1.1.18.ebuild without a revision bump to -r1. > - What is $(PORTAGE_BUILDDIR) supposed to do? These should be curly {} > braces. > - PORTAGE_BUILDDIR is not defined by PMS but an internal variable of > Portage, so ebuilds must not use it. > - Missing "|| die" after the sed command. > > New fix committed here: > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=cd295fdf21d6afba9018e518f92e6e8c94e1c457 > > Please test. Ran 'ebuild sbcl-1.1.18 compile' successfully. I also reviewed the changes and I don't have a problem with them. Sorry about the QA violations. I'm still a bit new to ebuild writing. (In reply to nvinson234 from comment #7) > > Please test. > > Ran 'ebuild sbcl-1.1.18 compile' successfully. I also reviewed the changes > and I don't have a problem with them. Thanks, marking as FIXED then. > Sorry about the QA violations. I'm still a bit new to ebuild writing. Really no need to apologise for submitting a fix. :) Some things went under the radar of the proxy-maintainers' review, which can happen as they cannot be familiar with all packages. |