Bug 571728

Summary:	media-video/mpv-0.14.0: gpl3 USE flag request
Product:	Gentoo Linux	Reporter:	Alex <fhlfibh>
Component:	Current packages	Assignee:	Coacher <itumaykin+gentoo>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	maksbotan, nikoli, yngwin
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/mpv-player/mpv/blob/17507b593506ad820cfabbe2fcec208ffe9d073f/video/out/opengl/nnedi3.c#L39
See Also:	https://github.com/mpv-player/mpv/issues/2600 https://bugs.gentoo.org/show_bug.cgi?id=506946 https://github.com/mpv-player/mpv/pull/3236
Whiteboard:
Package list:		Runtime testing required:	---

Description Alex 2016-01-13 11:21:22 UTC

Hi!

MPV devs say since 0.14.0 "vo_opengl: require --enable-gpl3 for nnedi".
https://github.com/mpv-player/mpv/releases

It seems mpv-0.14.0 comes with gpl3 disabled, and there's no USE flag or something to enable it.

Is it possible to add some?

Regards,
Alex

Comment 1 Coacher 2016-01-13 13:50:56 UTC

Hello.

I am aware of the --enable-gpl3 configure option. However, the licensing of the code in question is very unclear, see URL and line 17 in the same file.

Upstream itself is not sure what license should be applied to this code, see commit message in URL.

mpv's license information is rather complicated as it is, see bug #506946.
Thus until there is a clear resolution from upstream what actual license(s) should be applied with --enable-gpl3 switch, it will stay disabled, since we are talking about rather minor feature here.

I am closing this bug for now. If you can gather the needed information, please feel free to reopen this bug and post it here.

Comment 2 Patrice Clement (RETIRED) gentoo-dev

2016-01-13 14:37:07 UTC

commit 3b0ab23 (HEAD, master)
Merge: 4e4dfb5 79aef40
Author: Patrice Clement <monsieurp@gentoo.org>
Date:   Wed Jan 13 14:33:46 2016 +0000

    Merge remote-tracking branch 'github/pr/648'. Fixes bug 571728.

Comment 3 Coacher 2016-01-13 14:45:24 UTC

(In reply to Patrice Clement from comment #2)

Patrice, unfortunately this bug is not properly fixed yet.
The change you've mentioned is intended to provide a reference to this bug for anyone curious enough to look through the ebuild. We still need upstream to clarify the situation around --enable-gpl3 switch.

Thus I'll revert it back to RESOLVED UPSTREAM.

Comment 4 Patrice Clement (RETIRED) gentoo-dev

2016-01-13 14:49:53 UTC

no worries, you're the captain here ;)

Comment 5 Coacher 2016-06-21 11:36:50 UTC

Upstream removed the code in question from mpv recently.
This change will be available in the next release after 0.17.0.
See https://github.com/mpv-player/mpv/pull/3236

NNEDI3 prescaler was moved to https://github.com/bjin/mpv-prescalers.
Currently you need mpv-9999 to use NNEDI3 from this repo.